Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CloudWatchFullAccessV2 managed policy (#2913) #2978

Conversation

JustinTW
Copy link
Contributor

No description provided.

Copy link

PR is now waiting for a maintainer to run the acceptance tests.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@JustinTW JustinTW force-pushed the enhancement/add-cloudWatchcullaccessv2-managed-policy branch from a37e937 to 84a9515 Compare November 14, 2023 03:46
Copy link

PR is now waiting for a maintainer to run the acceptance tests.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@iwahbe
Copy link
Member

iwahbe commented Nov 21, 2023

/run-acceptance-tests

@pulumi-bot
Copy link
Contributor

Please view the PR build: https://github.com/pulumi/pulumi-aws/actions/runs/6938379386

@iwahbe
Copy link
Member

iwahbe commented Nov 21, 2023

Hey @JustinTW. Thanks for the contribution!

I can't find where AWS says that CloudWatchFullAccess will be deprecated on December 7. Can you link that?

If CloudWatchFullAccess is deprecated, we can add a deprecation message:

 provider/resources.go                              |   7 +-
 1 file changed, 5 insertions(+), 2 deletions(-)

--- a/provider/resources.go
+++ b/provider/resources.go
@@ -5644,8 +5644,11 @@ $ pulumi import aws:networkfirewall/resourcePolicy:ResourcePolicy example arn:aw
 					{Name: "CloudWatchEventsInvocationAccess", Value: "arn:aws:iam::aws:policy/service-role/CloudWatchEventsInvocationAccess"},
 					{Name: "CloudWatchEventsReadOnlyAccess", Value: "arn:aws:iam::aws:policy/CloudWatchEventsReadOnlyAccess"},
 					{Name: "CloudWatchEventsServiceRolePolicy", Value: "arn:aws:iam::aws:policy/aws-service-role/CloudWatchEventsServiceRolePolicy"},
-					// After December 7, 2023, "CloudWatchFullAccess" will no longer be supported. Use "CloudWatchFullAccessV2" instead.
-					{Name: "CloudWatchFullAccess", Value: "arn:aws:iam::aws:policy/CloudWatchFullAccess"},
+					{
+						Name:               "CloudWatchFullAccess",
+						Value:              "arn:aws:iam::aws:policy/CloudWatchFullAccess",
+						DeprecationMessage: `After December 7, 2023, "CloudWatchFullAccess" will no longer be supported. Use "CloudWatchFullAccessV2" instead.`,
+					},
 					{Name: "CloudWatchFullAccessV2", Value: "arn:aws:iam::aws:policy/CloudWatchFullAccessV2"},
 					{Name: "CloudWatchInternetMonitorServiceRolePolicy", Value: "arn:aws:iam::aws:policy/aws-service-role/CloudWatchInternetMonitorServiceRolePolicy"},
 					{Name: "CloudWatchLambdaInsightsExecutionRolePolicy", Value: "arn:aws:iam::aws:policy/CloudWatchLambdaInsightsExecutionRolePolicy"},

Copy link

PR is now waiting for a maintainer to run the acceptance tests.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@JustinTW
Copy link
Contributor Author

JustinTW commented Nov 21, 2023

Hello @iwahbe,

Thanks for reviewing this PR. I also couldn't find any AWS documentation that specifies that CloudWatchFullAccess will be deprecated on December 7. The only thing I have is an email from AWS, which I've attached.

The relevant AWS documentation does mention that the policy will be deprecated, but it doesn't specify a date.

https://docs.aws.amazon.com/AmazonCloudWatch/latest/monitoring/auth-and-access-control-cw.html#managed-policies-cloudwatch-CloudWatchFullAccess

image

@iwahbe iwahbe self-requested a review November 21, 2023 19:03
Copy link

PR is now waiting for a maintainer to run the acceptance tests.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

Copy link
Member

@iwahbe iwahbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I have confirmed that the message is correct (the email helped!).

LGTM

@iwahbe iwahbe merged commit 165cbee into pulumi:master Nov 21, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants