-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CloudWatchFullAccessV2 managed policy (#2913) #2978
Add CloudWatchFullAccessV2 managed policy (#2913) #2978
Conversation
PR is now waiting for a maintainer to run the acceptance tests. |
Signed-off-by: Justin CT Liu <[email protected]>
a37e937
to
84a9515
Compare
PR is now waiting for a maintainer to run the acceptance tests. |
/run-acceptance-tests |
Please view the PR build: https://github.com/pulumi/pulumi-aws/actions/runs/6938379386 |
Hey @JustinTW. Thanks for the contribution! I can't find where AWS says that CloudWatchFullAccess will be deprecated on December 7. Can you link that? If provider/resources.go | 7 +-
1 file changed, 5 insertions(+), 2 deletions(-)
--- a/provider/resources.go
+++ b/provider/resources.go
@@ -5644,8 +5644,11 @@ $ pulumi import aws:networkfirewall/resourcePolicy:ResourcePolicy example arn:aw
{Name: "CloudWatchEventsInvocationAccess", Value: "arn:aws:iam::aws:policy/service-role/CloudWatchEventsInvocationAccess"},
{Name: "CloudWatchEventsReadOnlyAccess", Value: "arn:aws:iam::aws:policy/CloudWatchEventsReadOnlyAccess"},
{Name: "CloudWatchEventsServiceRolePolicy", Value: "arn:aws:iam::aws:policy/aws-service-role/CloudWatchEventsServiceRolePolicy"},
- // After December 7, 2023, "CloudWatchFullAccess" will no longer be supported. Use "CloudWatchFullAccessV2" instead.
- {Name: "CloudWatchFullAccess", Value: "arn:aws:iam::aws:policy/CloudWatchFullAccess"},
+ {
+ Name: "CloudWatchFullAccess",
+ Value: "arn:aws:iam::aws:policy/CloudWatchFullAccess",
+ DeprecationMessage: `After December 7, 2023, "CloudWatchFullAccess" will no longer be supported. Use "CloudWatchFullAccessV2" instead.`,
+ },
{Name: "CloudWatchFullAccessV2", Value: "arn:aws:iam::aws:policy/CloudWatchFullAccessV2"},
{Name: "CloudWatchInternetMonitorServiceRolePolicy", Value: "arn:aws:iam::aws:policy/aws-service-role/CloudWatchInternetMonitorServiceRolePolicy"},
{Name: "CloudWatchLambdaInsightsExecutionRolePolicy", Value: "arn:aws:iam::aws:policy/CloudWatchLambdaInsightsExecutionRolePolicy"}, |
PR is now waiting for a maintainer to run the acceptance tests. |
Hello @iwahbe, Thanks for reviewing this PR. I also couldn't find any AWS documentation that specifies that CloudWatchFullAccess will be deprecated on December 7. The only thing I have is an email from AWS, which I've attached. The relevant AWS documentation does mention that the policy will be deprecated, but it doesn't specify a date. |
PR is now waiting for a maintainer to run the acceptance tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. I have confirmed that the message is correct (the email helped!).
LGTM
No description provided.