Test tf defaults #3157
Closed
Test tf defaults #3157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does the PR have any schema changes?Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
VenelinMartinov
added a commit
to pulumi/pulumi-terraform-bridge
that referenced
this pull request
Dec 28, 2023
This PR fixes an inconsistency in how we treat defaults versus TF. Previously we would have applied defaults before validating input. TF does the reverse. Should address #1546. Tested in AWS here: pulumi/pulumi-aws#3157 Note that this PR technically introduces a breaking change. An example of how it'd manifest is in [TestDefaultsAndRequiredWithValidationInteraction/CheckMissingRequiredWith](https://github.com/pulumi/pulumi-terraform-bridge/blob/5ef834fd75b7c259dacc8fb71a0cc6edfd2472bc/pkg/tfbridge/provider_test.go#L2514). Previously we'd apply the defaults before passing to the TF provider for validation, so this test case would have yielded no failures. This is not what TF does - TF would fail validation on that input. We will now match the TF behaviour and fail this input. This should be fine as the input likely does not make sense anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tests pulumi/pulumi-terraform-bridge#1583 in aws