-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: enable release verification take 2 #5053
Conversation
Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5053 +/- ##
=======================================
Coverage 24.42% 24.42%
=======================================
Files 360 360
Lines 143403 143403
=======================================
Hits 35023 35023
Misses 108281 108281
Partials 99 99 ☔ View full report in Codecov by Sentry. |
runtime: python | ||
runtime: | ||
name: python | ||
options: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is required based on https://github.com/pulumi/verify-provider-release?tab=readme-ov-file#python
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the existing nodejs example tests required a config value to be set. Copied over the bucket
example and removed that config.
@@ -23,6 +23,7 @@ COMMANDS | |||
check_in Write checkedout commits back to patches, add upstream | |||
and patches changes to the git staging area and exit | |||
checkout mode. | |||
file_target Print a file path to depend on in make. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This came from ci-mgmt yes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's try this.
This PR has been shipped in release v6.66.3. |
This enables release verification for AWS.
Tested by manually executing the
Verify-Release
workflow using this branch. Run can be seen here https://github.com/pulumi/pulumi-aws/actions/runs/12691069824closes pulumi/ci-mgmt#1265