chore: remove make extenders #5110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5110 +/- ##
=======================================
Coverage 24.46% 24.46%
=======================================
Files 361 361
Lines 144037 144037
=======================================
Hits 35243 35243
Misses 108696 108696
Partials 98 98 ☔ View full report in Codecov by Sentry. |
t0yv0
force-pushed
the
t0yv0/remove-make-extenders
branch
from
6d28660 to
9842596
Compare
flostadler
approved these changes
Jan 17, 2025
| @@ -5,6 +5,9 @@ parallel: 1 | |||
| timeout: 150 | |||
| generate-nightly-test-workflow: true | |||
| providerVersion: github.com/hashicorp/terraform-provider-aws/version.ProviderVersion | |||
|
|
|||
| buildProviderPre: "VERSION=${VERSION_GENERIC} ./scripts/minimal_schema.sh" | |||
There was a problem hiding this comment.
So we basically replaced makefile extensions with a generic shell based pointcut?
There was a problem hiding this comment.
Yes. It has a slight advantage that it does not interact with make --touch wildly, and it's documented in the cimgmt config.
|
This PR has been shipped in release v6.67.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move minimal schema computation from a .mk/ Make extension to a script. Update ci-mgmt workflows.