Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Onboard pulumi-awsx to ci-mgmt #1471

Merged
merged 26 commits into from
Jan 14, 2025
Merged

Onboard pulumi-awsx to ci-mgmt #1471

merged 26 commits into from
Jan 14, 2025

Conversation

t0yv0
Copy link
Member

@t0yv0 t0yv0 commented Jan 9, 2025 •
edited
Loading

This change swaps out custom GitHub actions workflows with workflows managed centrally in pulumi/ci-mgmt that are standard across Pulumi provider repositories.

Fixes pulumi/ci-mgmt#1191

Depends on pulumi/ci-mgmt#1287

Builds on top of pulumi/ci-mgmt#1275 using Bridged Makefile for this provider.

  • run all tests
    • cd awsx && yarn test is running via a .mk extender
    • cd awsx-classic/tests && yarn && yarn run build && yarn run mocha $$(find bin -name '*.spec.js') also known as istanbul-tests, these were not run in CI prior to the change
    • examples_legacy were not run as acceptance tests intentionally per README
    • examples are running
  • recover weekly-pulumi-update.yml
  • recover awsx-upgrade-aws.yml
  • ensure renovate can update the repo
  • ensure post-release verification
  • perform an alpha release
  • verify in each language the SDKs got versioned and usable

@t0yv0 t0yv0 mentioned this pull request Jan 9, 2025
Merged
t0yv0 added a commit that referenced this pull request Jan 9, 2025
@t0yv0
chore: alias schema to a new location (#1472)
cb982e9 
This is a temporary change to facilitate testing
#1471

The schema-tools expect schema to be found under a certain path but the
PR is moving the schema. The new location is enabled to reference the
old location.
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2025

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Maintainer note: consult the runbook for dealing with any breaking changes.

@codecov Codecov
Copy link

codecov bot commented Jan 9, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 447 lines in your changes missing coverage. Please review.

Please upload report for BASE (master@2f75144). Learn more about missing BASE report.

Files with missing lines Patch % Lines
provider/cmd/pulumi-gen-awsx/main.go 0.00% 153 Missing ⚠️
provider/pkg/schemagen/ec2.go 0.00% 110 Missing ⚠️
provider/pkg/schemagen/ecsx.go 0.00% 88 Missing ⚠️
provider/pkg/schemagen/ecr.go 0.00% 62 Missing ⚠️
provider/pkg/schemagen/lb.go 0.00% 20 Missing ⚠️
provider/pkg/schemagen/cloudtrail.go 0.00% 8 Missing ⚠️
provider/pkg/schemagen/iam.go 0.00% 6 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff            @@
##             master   #1471   +/-   ##
========================================
  Coverage          ?   0.00%           
========================================
  Files             ?      10           
  Lines             ?    2345           
  Branches          ?       0           
========================================
  Hits              ?       0           
  Misses            ?    2345           
  Partials          ?       0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@t0yv0 t0yv0 requested a review from rquitales January 9, 2025 22:30
@t0yv0 t0yv0 mentioned this pull request Jan 13, 2025
Closed
@t0yv0
Copy link
Member Author

t0yv0 commented Jan 14, 2025

Alpha release going out with release verification: https://github.com/pulumi/pulumi-awsx/actions/runs/12771403406

@t0yv0 t0yv0 changed the title wip: test CI changes Onboard repository to ci-mgmt Jan 14, 2025
@t0yv0 t0yv0 marked this pull request as ready for review January 14, 2025 17:57
@t0yv0 t0yv0 changed the title Onboard repository to ci-mgmt Onboard pulumi-awsx to ci-mgmt Jan 14, 2025
rquitales
rquitales reviewed Jan 14, 2025
View reviewed changes
.upgrade-config.yml
# WARNING: This file is autogenerated - changes will be overwritten when regenerated by https://github.com/pulumi/ci-mgmt

---
upstream-provider-name: terraform-provider-awsx
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's have a follow-up work item to remove referencing terraform. This could be confusing for users since awsx is not a bridged provider.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, looking.

rquitales
rquitales approved these changes Jan 14, 2025
View reviewed changes
Copy link
Member

@rquitales rquitales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Changes came mostly from other PRs that were reviewed with scrutiny. A sanity check of this PR looks good.

@t0yv0 t0yv0 enabled auto-merge (squash) January 14, 2025 21:27
@t0yv0
Copy link
Member Author

t0yv0 commented Jan 14, 2025

Looks like we need to disable branch protections temporarily and reset them via ci-mgmt.

@t0yv0 t0yv0 merged commit 3f6dc4e into master Jan 14, 2025
25 checks passed
@t0yv0 t0yv0 deleted the test-ci-changes branch January 14, 2025 21:28
@t0yv0 t0yv0 mentioned this pull request Jan 14, 2025
Merged
github-merge-queue bot pushed a commit to pulumi/ci-mgmt that referenced this pull request Jan 14, 2025
@t0yv0
Onboard AWSX (#1288)
86e53cf 
Following up on pulumi/pulumi-awsx#1471 where
the workflows are now ci-mgmt workflows.

This in particular should reset branch protections to expected ones
managed by ci-mgmt.
@pulumi-bot
Copy link
Contributor

This PR has been shipped in release v2.20.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rquitales rquitales rquitales approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Onboard pulumi-awsx to ci-mgmt
3 participants
@t0yv0 @pulumi-bot @rquitales