Increase timeout for TestAccEcsParallel
#1489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1489 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 10 10
Lines 2345 2345
======================================
Misses 2345 2345 ☔ View full report in Codecov by Sentry. |
corymhall
approved these changes
Jan 16, 2025
|
This PR has been shipped in release v2.21.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test verifies that components like ECS services are created/updated in parallel. This took 1+ hours to run before fixing pulumi/pulumi#7629.
The test started to become more flaky recently (see #1488), this coincides with upgrading the GitHub runners to Ubuntu 24.04 and onboarding awsx to ci-mgmt. Those changes might've affected the test runtime and 15 minutes were probably a bit too aggressive.
Updated the timeout to 30min, which is still well below the 1 hour it took before.
Fixes #1488