Skip to content

Commit

Permalink
Remove unused urn output for helm Chart resources (#2685)
Browse files Browse the repository at this point in the history
### Proposed changes

Pulumi v3.95 enforces strict validation that reserves `urn` and `id` for
their own usage. The `urn` output field in the helm Chart resource is
actually unused, and being shadowed by the underlying Pulumi `urn`
anyway. Removing this field will have no user facing impacts.

I have confirmed that running `pulumi --logtostderr package get-schema
kubernetes` passes using the locally built provider binary from this PR.

### Related issues (optional)

Fixes: #2683
  • Loading branch information
rquitales authored Dec 5, 2023
1 parent 5e811c9 commit 8016ea6
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 10 deletions.
4 changes: 0 additions & 4 deletions provider/cmd/pulumi-resource-kubernetes/schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -81062,10 +81062,6 @@
"resources": {
"type": "string",
"description": "Resources created by the Chart."
},
"urn": {
"type": "string",
"description": "The stable logical URN used to distinctly address a resource, both before and after deployments."
}
},
"type": "object",
Expand Down
6 changes: 0 additions & 6 deletions provider/pkg/gen/overlays.go
Original file line number Diff line number Diff line change
Expand Up @@ -63,12 +63,6 @@ var helmV3ChartResource = pschema.ResourceSpec{
},
Description: "Resources created by the Chart.",
},
"urn": {
TypeSpec: pschema.TypeSpec{
Type: "string",
},
Description: "The stable logical URN used to distinctly address a resource, both before and after deployments.",
},
},
Type: "object",
},
Expand Down

0 comments on commit 8016ea6

Please sign in to comment.