Break circular dependency between provider/tests #3385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blampe
added
the
impact/no-changelog-required
Does the PR have any schema changes?Looking good! No breaking changes found. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3385 +/- ##
==========================================
- Coverage 41.14% 41.08% -0.07%
==========================================
Files 85 87 +2
Lines 12764 12900 +136
==========================================
+ Hits 5252 5300 +48
- Misses 7122 7205 +83
- Partials 390 395 +5 ☔ View full report in Codecov by Sentry. |
rquitales
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
./testsmodules currently depends on the./providermodule for some OpenAPI helpers, but./provideralso depends on./testsfor Gomega matchers.Since
./testsisn't versioned like a proper module this puts us in a situation where Renovate will continuously try to update it #3384We can teach Renovate to ignore this bump, or we can break the dependency by moving some code around. I've opted for the latter, moving
tests/gomegatoprovider/pkg/gomega. (This makes it easier to consume from other projects if we want to.)Of course it's worth mentioning this is a self-inflicted problem due to our module structure. Related pulumi/ci-mgmt#1238.