Merge pull request #106 from justinstoller/timeout-errors

(PE-39731) Log request info on failure or cancellation
puppetlabs · Jan 8, 2025 · 12b4712 · 12b4712
2 parents 89dc1ce + 898ccc0
commit 12b4712
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/src/java/com/puppetlabs/http/client/impl/JavaClient.java b/src/java/com/puppetlabs/http/client/impl/JavaClient.java
@@ -344,6 +344,7 @@ private static void completeResponse(ResponseDeliveryDelegate responseDeliveryDe
                     contentType,
                     callback);
         } catch (Exception e) {
+            LOGGER.error("Processing successful request to {} raised '{}'", requestOptions.getUri().toString(), e.getMessage());
             responseDeliveryDelegate.deliverResponse(requestOptions, e, callback);
         }
     }
@@ -479,11 +480,13 @@ public void completed(HttpResponse httpResponse) {
 
             @Override
             public void failed(Exception e) {
+                LOGGER.error("{} request to '{}' failed.", method.toString(), requestOptions.getUri().toString());
                 responseDeliveryDelegate.deliverResponse(requestOptions, e, callback);
             }
 
             @Override
             public void cancelled() {
+                LOGGER.error("{} request to '{}' cancelled.", method.toString(), requestOptions.getUri().toString());
                 responseDeliveryDelegate.deliverResponse(requestOptions,
                         new HttpClientException("Request cancelled"),
                         callback);