(maint) add support for multiple Set-Cookie headers in a response #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The design of the client does not allow multiple entries for the same header name, as headers are returned in a map, rather than an array of them. As a result, headers like "Set-Cookie" would only return the last one seen if they were encountered. This alters the behavior to concatenate any of the "Set-Cookie" entries together, separated by a newline character. This seems to be a fairly common convention for clients that use headers with maps. Tests were updated to include multiple cookies, and demonstrate the behavior.
In leiningen 2.11.0, composite profiles became a warning. This removes the use of them in favor of explicit profiles to remove the warning.
|
The eastwood failure is related to a lein 2.11.1 and eastwood incompatibility. When run locally with an older version of lein, it all passes: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The design of the client does not allow multiple entries for the
same header name, as headers are returned in a map, rather than
an array of them. As a result, headers like "Set-Cookie" would only
return the last one seen if they were encountered. This alters the
behavior to concatenate any of the "Set-Cookie" entries together,
separated by a newline character. This seems to be a fairly common
convention for clients that use headers with maps.
Tests were updated to include multiple cookies, and demonstrate
the behavior.