Call Module#const_get once per Module

puppetlabs · Dec 8, 2023 · 4b00be7 · 4b00be7
1 parent ba58f16
commit 4b00be7
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/lib/facter/framework/core/fact_loaders/class_discoverer.rb b/lib/facter/framework/core/fact_loaders/class_discoverer.rb
@@ -21,9 +21,10 @@ def discover_classes(operating_system)
 
     def find_nested_classes(mod, discovered_classes)
       mod.constants.each do |constant_name|
-        if mod.const_get(constant_name).instance_of? Class
-          discovered_classes << mod.const_get(constant_name)
-        elsif mod.const_get(constant_name).instance_of? Module
+        obj = mod.const_get(constant_name)
+        if obj.instance_of? Class
+          discovered_classes << obj
+        elsif obj.instance_of? Module
           find_nested_classes(Module.const_get("#{mod.name}::#{constant_name}"), discovered_classes)
         end
       end