Fix mod_auth_openidc parameters
#2525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A typo in the data type cause an exception with recent Puppet 8 versions: ``` Error: The key '["IDTokenEncryptedResponseAlg"]' is declared more than once (file: /etc/puppetlabs/code/environments/production/modules/apache/types/oidcsettings.pp, line: 41, column: 57) on node b4d45d8831d5.mtgrj3ika5nejlcpzgeeecg0la.cx.internal.cloudapp.net ``` According to the upstream repository configuration file, this is a copy-paste error.
ekohl
approved these changes
Feb 16, 2024
|
It was introduced in 9f7f38f. How did we not find this before? I see we don't have a test for the type in |
|
Lack of tests might not help indeed. The new Puppet 8 ensuring there is no duplicate allows us to find such issues now, so I guess this is okay. The ARM builds seems currently broken (or at least not reliable as they do not start), and I think we can ignore them. I will merge this so that we can move on on other PR broken by this typo. |
kenyon
added a commit
to kenyon/puppet
that referenced
this pull request
Mar 1, 2024
evgeni
added a commit
to theforeman/puppet-foreman
that referenced
this pull request
Mar 18, 2024
We need 12.0.3+ for Puppet 8 support due to puppetlabs/puppetlabs-apache#2525
evgeni
added a commit
to theforeman/puppet-pulpcore
that referenced
this pull request
Mar 18, 2024
We need 12.0.3+ for Puppet 8 support due to puppetlabs/puppetlabs-apache#2525
evgeni
added a commit
to theforeman/puppet-katello
that referenced
this pull request
Mar 18, 2024
We need 12.0.3+ for Puppet 8 support due to puppetlabs/puppetlabs-apache#2525
evgeni
added a commit
to theforeman/puppet-foreman_proxy_content
that referenced
this pull request
Mar 18, 2024
We need 12.0.3+ for Puppet 8 support due to puppetlabs/puppetlabs-apache#2525
evgeni
added a commit
to theforeman/foreman-installer
that referenced
this pull request
Mar 18, 2024
We need 12.0.3+ for Puppet 8 support due to puppetlabs/puppetlabs-apache#2525
4 tasks
ekohl
pushed a commit
to theforeman/puppet-foreman
that referenced
this pull request
Mar 18, 2024
We need 12.0.3+ for Puppet 8 support due to puppetlabs/puppetlabs-apache#2525
ekohl
pushed a commit
to theforeman/puppet-pulpcore
that referenced
this pull request
Mar 18, 2024
We need 12.0.3+ for Puppet 8 support due to puppetlabs/puppetlabs-apache#2525
ekohl
pushed a commit
to theforeman/puppet-katello
that referenced
this pull request
Mar 18, 2024
We need 12.0.3+ for Puppet 8 support due to puppetlabs/puppetlabs-apache#2525
ekohl
pushed a commit
to theforeman/puppet-foreman_proxy_content
that referenced
this pull request
Mar 18, 2024
We need 12.0.3+ for Puppet 8 support due to puppetlabs/puppetlabs-apache#2525
evgeni
added a commit
to theforeman/foreman-installer
that referenced
this pull request
Mar 18, 2024
We need 12.0.3+ for Puppet 8 support due to puppetlabs/puppetlabs-apache#2525
rdcuzins
pushed a commit
to Puppet-Finland/puppetlabs-apache
that referenced
this pull request
Oct 4, 2024
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A typo in the data type cause an exception with recent Puppet 8
versions:
According to the upstream repository configuration file, this is a
copy-paste error.