-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop managing mime support package on Debian #2526
Conversation
All apache2 packages on Debian 10 and later already have a hard dependency on the `mime-support` package. While `mime-support` still exists on Debian 12 as a transitonal package, upcoming Debian 13 has removed it entirely. This sets the `$mime_support_package` to undefined so that the package isn't managed on Debian, since it doesn't need to be.
06ed2a1
to
95a2ab0
Compare
IMHO the default should stay unchanged for Debian 11 and 12 for the time being. So maybe add something like this in params.pp:
|
Why, if the packaging already has a hard dependency then why not rely on that? |
Accepting this change will allow Debian 12 users to get rid of the transitional, dummy package |
Sorry, misunderstanding no my side please ignore my comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approved CI, so waiting on that to finish.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks sane!
Summary
All apache2 packages on Debian 10 and later already have a hard dependency on the
mime-support
package. Whilemime-support
still exists on Debian 12 as a transitonal package, upcoming Debian 13 has removed it entirely.This sets the
$mime_support_package
to undefined so that the package isn't managed on Debian, since it doesn't need to be.Additional Context
Currently, the module fails completely on Debian testing (upcoming release 13 codenamed
trixie
):Checklist
puppet apply
)