Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PE-38816 Tests added for add_replica to cover replica_postgresql_host parameter #473

Closed
wants to merge 2 commits into from

Conversation

AaronShannon
Copy link
Contributor

@AaronShannon AaronShannon commented Aug 6, 2024

Summary

Provide a detailed description of all the changes present in this pull request.

Additional Context

Add any additional context about the problem here.

Related Issues (if any)

Mention any related issues or pull requests.

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.

Changes include test coverage?

  • Yes
  • Not needed

Have you updated the documentation?

  • Yes, I've updated the appropriate docs
  • Not needed

@AaronShannon AaronShannon marked this pull request as ready for review August 6, 2024 14:54
@AaronShannon AaronShannon requested review from a team as code owners August 6, 2024 14:54
@ragingra
Copy link
Member

@AaronShannon I've just removed that param, so might not need this anymore! #520

@AaronShannon AaronShannon deleted the PE-38816-add_replica-Unit-Tests branch October 29, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants