Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

puppet_runonce: redirect stderr to stdout #523

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

bastelfreak
Copy link
Collaborator

@bastelfreak bastelfreak commented Nov 1, 2024

In case the Puppet Agent fails, it prints an error to stderr. Previously when running the task, and the agent failed, it would output only normal stdout, which contained only successful changes, and actual errors were hidden.

Summary

Provide a detailed description of all the changes present in this pull request.

Additional Context

Add any additional context about the problem here.

Related Issues (if any)

Mention any related issues or pull requests.

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.

Changes include test coverage?

  • Yes
  • Not needed

Have you updated the documentation?

  • Yes, I've updated the appropriate docs
  • Not needed

@bastelfreak bastelfreak self-assigned this Nov 1, 2024
@bastelfreak bastelfreak requested review from a team as code owners November 1, 2024 16:12
Copy link
Member

@ragingra ragingra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change. One failing test seems unrelated, happy for it to go in anyway.

In case the Puppet Agent fails, it prints an error to stderr. Previously
when running the task, and the agent failed, it would output only normal
stdout, which contained only successful changes, and actual errors were
hidden.
@ragingra ragingra merged commit 66567dc into puppetlabs:main Dec 5, 2024
70 checks passed
vchepkov pushed a commit to vchepkov/puppetlabs-peadm that referenced this pull request Dec 14, 2024
In case the Puppet Agent fails, it prints an error to stderr. Previously
when running the task, and the agent failed, it would output only normal
stdout, which contained only successful changes, and actual errors were
hidden.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants