Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PE-39351) Update add_database plan to work with patching/HAC #531

Merged
merged 3 commits into from
Dec 16, 2024
Merged

Conversation

mcdonaldseanp
Copy link
Contributor

@mcdonaldseanp mcdonaldseanp commented Dec 11, 2024

This commit updates the add_database plan to include the pe-patching and pe-hac databases when it cleans up the original postgres on the primary.

The add_database plan uses pg_basebackup to copy the entire contents of the postgres DB from the original primary DB to the new DB node's postgres. That process doesn't individually update a list of databases, so there's no context of "which DBs to move", because it just moves everything. However, during the cleanup process on the original DB That exists on the primary, the plan does need to list the individual internal postgres dbs that need to be deleted.

Summary

Provide a detailed description of all the changes present in this pull request.

Additional Context

Add any additional context about the problem here.

Related Issues (if any)

Mention any related issues or pull requests.

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.

Changes include test coverage?

  • Yes
  • Not needed

Have you updated the documentation?

  • Yes, I've updated the appropriate docs
  • Not needed

@mcdonaldseanp mcdonaldseanp requested review from a team as code owners December 11, 2024 21:20
functions/pe_db_names.pp Outdated Show resolved Hide resolved
This commit updates the add_database plan to include the pe-patching and
pe-hac databases when it cleans up the original postgres on the primary.

The add_database plan uses pg_basebackup to copy the entire contents of
the postgres DB from the original primary DB to the new DB node's
postgres. That process doesn't individually update a list of databases,
so there's no context of "which DBs to move", because it just moves
everything. However, during the cleanup process on the original DB That
exists on the primary, the plan _does_ need to list the individual
internal postgres dbs that need to be deleted.
@jhbuchanan45
Copy link
Contributor

jhbuchanan45 commented Dec 12, 2024

@mcdonaldseanp I've rebased this on main to get CI running with bolt 4. Hopefully by the time you're online CI should be mostly done then

@ragingra ragingra merged commit 09d80bb into main Dec 16, 2024
70 checks passed
@ragingra ragingra deleted the PE39351 branch December 16, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants