Role Valid Until Date

[mooreandrew]

Summary

I have a requirement to set valid until dates for roles that I need to manage via this puppet postgresql module. This change adds support for setting a valid_until attribute for a role.

Related Issues (if any)

None

Checklist

• 🟢 Spec tests.
• 🟢 Acceptance tests.
• Manually verified. (For example puppet apply)

[CLAassistant]

All committers have signed the CLA.

[smortex]

See CI failures about missing documentation. Also, adding tests to spec/defines/server/role_spec.rb to ensure the feature don't break in the future would be nice.

[mooreandrew]

@smortex I've updated the code, adding documentation for the variable and tests to spec/defines/server_instance_spec.rb in the same way as the other alter commands.

Let me know if that is good or if you need me to make any further changes.

[mooreandrew]

@smortex The pipeline all appears to look good. How can I got this change merged?

[alexjfisher]

Looks okay to me too. Only query is should this have a mechanism for removing the expiry date? eg. perhaps if the parameter is set to a special value such as the string 'absent' or maybe the boolean false (in which case you'd probably need unless $valid_until == undef { instead of if $valid_until { for your conditional), then rolvaliduntil should be set to NULL (unless it's already NULL)

[smortex]

Looks okay to me too. Only query is should this have a mechanism for removing the expiry date? eg. perhaps if the parameter is set to a special value such as the string 'absent' or maybe the boolean false (in which case you'd probably need unless $valid_until == undef { instead of if $valid_until { for your conditional), then rolvaliduntil should be set to NULL (unless it's already NULL)

That would make sense, @mooreandrew feel free to tackle this if you want to. In the meantime, this PR is fine so I'll merge it as it is now.

Thanks!

[alexjfisher]

Looks okay to me too. Only query is should this have a mechanism for removing the expiry date? eg. perhaps if the parameter is set to a special value such as the string 'absent' or maybe the boolean false (in which case you'd probably need unless $valid_until == undef { instead of if $valid_until { for your conditional), then rolvaliduntil should be set to NULL (unless it's already NULL)

That would make sense, @mooreandrew feel free to tackle this if you want to. In the meantime, this PR is fine so I'll merge it as it is now.

Thanks!

Yeah, I'm fine with that. This MR is safe as-is, and the additional functionality can be added later in a non disruptive way.