(PA-6760) Update task_acceptance tests for MacOS15 ARM #752
Conversation
skyamgarp
force-pushed
the
PA-6760
branch
3 times, most recently
from
7e43f60 to
46c08a4
Compare
| when %r{ubuntu-24.04} | ||
| '7.32.1' | ||
| when latest_platform_list | ||
| 'latest' |
There was a problem hiding this comment.
Since latest_platform_list includes macOS 15, this seems to imply we should install puppet7 nightly on macOS 15, but we know that's not supported...
I'm wondering if it would be clearer to separate the different use cases as:
- Happy Path: There are puppet7 and 8 released versions available. Install the earliest puppet7 version and upgrade to puppet 8.
- New Agent hasn't been released yet (like macOS 15 is now). Install the latest dev version.
- New Agent recently released (like macOS 15 will be in March). Install the earliest puppet8 version and upgrade to the latest dev version.
- New Agent with multiple releases (like macOS 15 after 8.12.0 comes out). Install the earliest puppet8 version and upgrade to the latest released version.
All 4 cases should be idempotent, so after the step is finished, if you run puppet agent -t again, it shouldn't attempt to upgrade/downgrade.
There was a problem hiding this comment.
This won't be applicable as this is in the else part of the case which won't be matched when we are running tests for macos15. I will remove this part to reduce ambiguity.
There was a problem hiding this comment.
This PR targets the 2nd case and 1st is existing behaviour, for 3rd case we have a separate jira in which maybe we can add 4th case as well or have new jira for same.
|
|
||
| # Use nightlies for unreleased platforms | ||
| # puppet_7_collection = 'puppet7-nightly' | ||
| # puppet_8_collection = 'puppet8-nightly' |
There was a problem hiding this comment.
Nit, these 3 lines aren't applicable anymore, could you remove them?
| # false | ||
| # else | ||
| # true | ||
| # end |
There was a problem hiding this comment.
nit, could you remove the commented out block that starts with multiple_puppet7_versions
| # true | ||
| # end | ||
| multiple_puppet7_versions = case target_platform | ||
| when %r{el-9-ppc64le|amazon-2|ubuntu-24|fedora-40} |
There was a problem hiding this comment.
| when %r{el-9-ppc64le|amazon-2|ubuntu-24|fedora-40} | |
| when # %r{operatingsystem-version-architecture} |
That line was added when those platforms were added in 7.31.0. See https://github.com/puppetlabs/puppetlabs-puppet_agent/pull/752/files#diff-49e04ead14b575f80ad5dc0542c02aaabd03fffe27b8098d8afaec6659378544R101-R102
Since there have been multiple releases since 7.31.0, we should be able to test 7.x to 7.y upgrades on those platforms.
|
Changes look good. Could you run adhoc pipeline against your branch on all supported platforms |
(PA-6760) Updated tests (PA-6760) Fix rubocop (PA-6760) Updated mac_source (PA-6760) Updated tests (PA-6760) Updated tests
|
For task_acceptance tests we don't have ad-hoc pipeline. Tested on local for macos-15 arm and macos14 arm. |
For MacOS 15(ARM) -
With this PR we are trying to only install puppet8. The upgrade part we will cover with another jira.
We don't support puppet7 for MacOS 15(ARM). So we don't need tests to upgrade the agent from puppet7 to puppet 8.