Call purescript with the shell enabled on Windows, as a workaround for CVE-2024-27980 #1308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following CVE-2024-27980, Node introduced a mitigation, where it forces callers of the
ChildProcess.spawnfunction to call it withshell: truefor.cmdfiles.This sounds like a very specific set of conditions, but we are affected - see #1219.
We are also quite removed from the place that calls
spawn(as we go through execa), but this patch fixes #1219 by passingshell: true(somehow) to command calls on Windows that end with.cmd