Add addJS method to PdfFileWriter #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What brilliant luck that the day I need this feature is the day after it is written! I can confirm that this feature works (after fairly minimal testing!) |
|
Thank you! |
mstamy2
added a commit
that referenced
this pull request
Jul 3, 2014
Add addJS method to PdfFileWriter
| @@ -106,7 +106,8 @@ def __init__(self): | |||
| NameObject("/Type"): NameObject("/Catalog"), | |||
| NameObject("/Pages"): self._pages, | |||
| }) | |||
| self._root = self._addObject(root) | |||
| self._root = None | |||
| self.root = root | |||
There was a problem hiding this comment.
What's the point of making the self.root attribute public?
There was a problem hiding this comment.
Couldn't call _addObject in init, hence the new var. You're right about the variable naming. Fixed it here: #119
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added addJS method to writer (taken from mfenniak/pyPdf#39)