Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STY: Use hasattr to determine if an object has an attribute #2718

Closed
wants to merge 2 commits into from
Closed

STY: Use hasattr to determine if an object has an attribute #2718

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dd847a0
STY: Use hasattr to determine if an object has an attribute with a gi…
j-t-1 Jun 17, 2024
f86a69f
Merge branch 'py-pdf:main' into hasattr
j-t-1 Jun 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pypdf/_writer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,7 +353,7 @@ def pdf_header(self, new_header: Union[str, bytes]) -> None:

def _add_object(self, obj: PdfObject) -> IndirectObject:
if (
getattr(obj, "indirect_reference", None) is not None
hasattr(obj, "indirect_reference")
and obj.indirect_reference.pdf == self # type: ignore
):
return obj.indirect_reference # type: ignore
Expand Down Expand Up @@ -387,7 +387,7 @@ def _replace_object(
indirect_reference = indirect_reference.idnum
gen = self._objects[indirect_reference - 1].indirect_reference.generation # type: ignore
if (
getattr(obj, "indirect_reference", None) is not None
hasattr(obj, "indirect_reference")
and obj.indirect_reference.pdf != self # type: ignore
):
obj = obj.clone(self)
Expand Down
Loading