MAINT: Add a comment

[j-t-1]

No description provided.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.36%. Comparing base (c6dcdc6) to head (f0b2eae).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3034   +/-   ##
=======================================
  Coverage   96.36%   96.36%           
=======================================
  Files          52       52           
  Lines        8770     8770           
  Branches     1595     1595           
=======================================
  Hits         8451     8451           
  Misses        191      191           
  Partials      128      128           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[j-t-1]

@stefan6419846 in test_parse_encoding_advanced_encoding_not_implemented, /WinAnsEncoding should be /WinAnsiEncoding. Do you know where is the corresponding change to fix this?

[stefan6419846]

The warnings are emitted in pypdf._cmap._parse_encoding. But the corresponding test file is just broken - we already should have support for the correct name:

pypdf/pypdf/_codecs/__init__.py

Line 44 in c6dcdc6

"/WinAnsiEncoding": _win_encoding,

[j-t-1]

So in tika-957144.pdf there is /WinAnsEncoding and this is deliberately chosen as a wrong encoding for the test?

[stefan6419846]

Yes:

%PDF-1.2
3 0 obj
<<
/Type /Font
/Subtype /Type1
/Name /F1
/BaseFont /Helvetica
/Encoding /WinAnsEncoding
>>
endobj
4 0 obj
<<
...

[stefan6419846]

Before merging, we probably need to have a look at #3035.