-
Notifications
You must be signed in to change notification settings - Fork 7
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fixes #14.
- Loading branch information
Showing
2 changed files
with
91 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
# Contributors Guidelines | ||
|
||
Contributions to py3minepi are welcome! Please adhere to the following | ||
contribution guidelines though: | ||
|
||
- Run the [test suite](https://github.com/py3minepi/py3minepi#testing) before | ||
committing and pushing your changes. | ||
- Please follow the [coding | ||
guidelines](https://github.com/py3minepi/py3minepi#coding-guidelines). | ||
- Use meaningful commit messages: First line of your commit message should be a | ||
very short summary (ideally 50 characters or less). After the first line of | ||
the commit message, add a blank line and then a more detailed explanation (when | ||
relevant). [This](http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html) | ||
is a nice blog post concerning git commit messages. | ||
- Add yourself to the [AUTHORS.txt | ||
file](https://github.com/py3minepi/py3minepi/blob/master/AUTHORS.txt). | ||
- Even if you have write access to the repository, never push commits directly | ||
to master. Always create a branch or a fork and post a pull request. The pull | ||
request will then be merged by someone other than you after at least 1 | ||
approving comment by a py3minepi organization member. | ||
|
||
The following items make our lifes easier, but are optional: | ||
|
||
- If you know how to use `git rebase`, please rebase/sqash your commits so that | ||
unnecessary noise in the commit history is avoided. | ||
- If you have have previously filed a GitHub issue and want to contribute code | ||
that addresses that issue, we prefer it if you use | ||
[hub](https://github.com/github/hub) to convert your existing issue to a pull | ||
request. To do that, first push the changes to a separate branch in your fork | ||
and then issue the following command: `hub pull-request -b py3minepi:master -i | ||
<issue-number> -h <your-github-username>:<your-branch-name>` This is no strict | ||
requirement though, if you don't have hub installed or prefer to use the web | ||
interface, then feel free to post a traditional pull request. | ||
|
||
Thanks for your contribution! |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters