Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two-bead parametrization for peptides #90

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mariusaarsten
Copy link
Contributor

Parametrization of two-bead model for peptides

Parametrization of two-bead model for peptides
@pm-blanco pm-blanco assigned pm-blanco and mariusaarsten and unassigned pm-blanco Sep 3, 2024
@pm-blanco pm-blanco self-requested a review September 3, 2024 10:58
@pm-blanco pm-blanco added the documentation Improvements or additions to documentation label Sep 3, 2024
Copy link
Collaborator

@pm-blanco pm-blanco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mariusaarsten Please add the metadata field, see parameters/peptides/Blanco2021.json. Do you know if your master thesis have been already been published at the NTNU repository? we should add the publication details in there.

@pm-blanco
Copy link
Collaborator

To be discussed with @kosovan: do you think that is a good idea to add this to the library? This is the first complete parametrization set for all aminoacids for the two bead model that we would have in pyMBE. We have validated it against the potentiometric titrations in @mariusaarsten thesis, which is going to be publicly available at the NTNU repository. However, the peptide sequences were not having all the aminoacids parametrized here so it is, of course, not ensured that it will provide reliable results for any arbitrary sequence. However, having the parametrization here has the added value that we can later use it for the testing the perspective new feature on dendrimers that will build on Marius' work.

@pm-blanco pm-blanco added this to the pyMBE 1.0.0 milestone Sep 3, 2024
@mariusaarsten
Copy link
Contributor Author

@pm-blanco The thesis should be published when it is graded, but the deadline for grading is in the beginning of November, so still quite a while. No need to add the metadata field before it is graded and published?

@pm-blanco
Copy link
Collaborator

@mariusaarsten I think that this PR can wait until your thesis is published. The file will not be used by any other part of pyMBE for now so it will not create any merge conflict while we keep developing the library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants