Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(types) Allow setting types for attributes #5460
feat(types) Allow setting types for attributes #5460
Changes from all commits
aa74fbe
4c263c1
4788d8c
bc8f095
c38836a
9e43986
9f34dcc
10d7b05
6dff59f
c8edd09
259ce93
7e380e2
b8ad03d
e5235f0
639b192
8da0ce0
886c9c2
31cc64f
4d0968d
e84df95
d660177
fe21e0f
4a443a7
008c370
b318d02
a53bf0e
adfed51
9160cb1
1571d52
07f8613
14d2dda
881b356
731745a
048b539
890fcae
28d2a66
3cbaafd
58e5a09
882d20f
b296137
981e0a3
7f7b70b
19e033c
375ea30
9f532cf
8b241f1
f205bb4
a6ffbe3
cd4f771
08d4774
1582971
fe04344
988c039
2241892
4be50fe
8f87e21
e6b1370
999b668
9d46b4d
921657a
e1e2c9a
2774a8d
6a6bff8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it maybe worth also adding a small test using
inspect.get_annotations()
for access?(only for 3.10+:
@pytest.mark.skipif(sys.version_info < (3, 10))
)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@InvincibleRMC could you please help with that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.