Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Clang dev CI job #5464

Merged
merged 2 commits into from
Dec 12, 2024
Merged

Drop Clang dev CI job #5464

merged 2 commits into from
Dec 12, 2024

Conversation

rwgk
Copy link
Collaborator

@rwgk rwgk commented Dec 12, 2024

Description

Dropping the "🐍 3 • Clang dev • C++11 • x64" job because it started failing.

I don't have the free bandwidth to debug. Help welcome.

For "last successful" and "first failing" information see comments below.

Changing from C++11 to C++17 did not help.

Suggested changelog entry:

@rwgk
Copy link
Collaborator Author

rwgk commented Dec 12, 2024

Failure with current master:

-- The CXX compiler identification is Clang 20.0.0
============================= test session starts ==============================
platform linux -- Python 3.11.2, pytest-7.2.1, pluggy-1.0.0+repack
C++ Info: Debian Clang 20.0.0 (++20241211083112+1bc1703eb5ba-1~exp1~20241211083133.1138) C++11 __pybind11_internals_v4_clang_libstdcpp_cxxabi1002__ PYBIND11_SIMPLE_GIL_MANAGEMENT=False PYBIND11_NUMPY_1_ONLY=False
rootdir: /__w/pybind11/pybind11/tests, configfile: pytest.ini
collected 957 items

../../tests/test_async.py ..                                             [  0%]
../../tests/test_buffers.py ...................................          [  3%]
../../tests/test_builtin_casters.py .....s..............                 [  5%]
../../tests/test_call_policies.py ........                               [  6%]
../../tests/test_callbacks.py .............s.                            [  8%]
../../tests/test_chrono.py ...........................................   [ 12%]
../../tests/test_class.py .....................................          [ 16%]
../../tests/test_const_name.py ......................                    [ 19%]
../../tests/test_constants_and_functions.py ......                       [ 19%]
../../tests/test_copy_move.py ....s....                                  [ 20%]
../../tests/test_cpp_conduit.py ....................                     [ 22%]
../../tests/test_custom_type_casters.py ...                              [ 22%]
../../tests/test_custom_type_setup.py ..                                 [ 23%]
../../tests/test_docs_advanced_cast_custom.py ..                         [ 23%]
../../tests/test_docstring_options.py .                                  [ 23%]
../../tests/test_eigen_matrix.py ......................ss.......         [ 26%]
../../tests/test_eigen_tensor.py ....................................... [ 30%]
......................................................................   [ 38%]
../../tests/test_enum.py ...........                                     [ 39%]
../../tests/test_eval.py ....                                            [ 39%]
../../tests/test_exceptions.py ..........................                [ 42%]
../../tests/test_factory_constructors.py ...............                 [ 43%]
../../tests/test_gil_scoped.py ......................................... [ 48%]
.................................................                        [ 53%]
../../tests/test_iostream.py ......................                      [ 55%]
../../tests/test_kwargs_and_defaults.py ........                         [ 56%]
../../tests/test_local_bindings.py ..........                            [ 57%]
../../tests/test_methods_and_attributes.py ........................      [ 60%]
../../tests/test_modules.py .......                                      [ 60%]
../../tests/test_multiple_inheritance.py ..................              [ 62%]
../../tests/test_numpy_array.py ........................................ [ 66%]
................................                                         [ 70%]
../../tests/test_numpy_dtypes.py ..........F....                         [ 71%]
../../tests/test_numpy_vectorize.py .......F                             [ 72%]
../../tests/test_opaque_types.py ...                                     [ 72%]
../../tests/test_operator_overloading.py .....                           [ 73%]
../../tests/test_pickling.py .........                                   [ 74%]
../../tests/test_python_multiple_inheritance.py ..                       [ 74%]
../../tests/test_pytypes.py .............................s.............. [ 79%]
..............................................................ssssssssss [ 86%]
s.                                                                       [ 86%]
../../tests/test_sequences_and_iterators.py .s...............            [ 88%]
../../tests/test_smart_ptr.py .............                              [ 90%]
../../tests/test_stl.py .........sss.sss.................                [ 93%]
../../tests/test_stl_binders.py ..............                           [ 94%]
../../tests/test_tagbased_polymorphic.py .                               [ 95%]
../../tests/test_thread.py ..                                            [ 95%]
../../tests/test_type_caster_pyobject_ptr.py .................           [ 97%]
../../tests/test_type_caster_std_function_specializations.py .           [ 97%]
../../tests/test_union.py .                                              [ 97%]
../../tests/test_unnamed_namespace_a.py Xx.x                             [ 97%]
../../tests/test_unnamed_namespace_b.py .                                [ 97%]
../../tests/test_vector_unique_ptr_member.py ....                        [ 98%]
../../tests/test_virtual_functions.py ..........                         [ 99%]
../../tests/test_warnings.py .......                                     [100%]

=================================== FAILURES ===================================
________________________________ test_vectorize ________________________________

    def test_vectorize():
        n = 3
        array = m.create_rec_simple(n)
        values = m.f_simple_vectorized(array)
>       np.testing.assert_array_equal(values, [0, 10, 20])

array      = array([(False, 0, 0. , -0. ), ( True, 1, 1.5, -2.5),
       (False, 2, 3. , -5. )],
      dtype={'names': ['bool_', 'uint_', 'float_', 'ldbl_'], 'formats': ['?', '<u4', '<f4', '<f16'], 'offsets': [0, 4, 8, 16], 'itemsize': 32})
n          = 3
values     = array([0, 0, 0], dtype=uint32)

../../tests/test_numpy_dtypes.py:404: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

args = (<built-in function eq>, array([0, 0, 0], dtype=uint32), [0, 10, 20])
kwds = {'err_msg': '', 'header': 'Arrays are not equal', 'strict': False, 'verbose': True}

    @wraps(func)
    def inner(*args, **kwds):
        with self._recreate_cm():
>           return func(*args, **kwds)
E           AssertionError: 
E           Arrays are not equal
E           
E           Mismatched elements: 2 / 3 (66.7%)
E           Max absolute difference: 20
E           Max relative difference: 1.
E            x: array([0, 0, 0], dtype=uint32)
E            y: array([ 0, 10, 20])

args       = (<built-in function eq>, array([0, 0, 0], dtype=uint32), [0, 10, 20])
func       = <function assert_array_compare at 0x7f737c5379c0>
kwds       = {'err_msg': '', 'header': 'Arrays are not equal', 'strict': False, 'verbose': True}
self       = <contextlib._GeneratorContextManager object at 0x7f737c08d790>

/usr/lib/python3.11/contextlib.py:81: AssertionError
___________________________ test_vectorized_noreturn ___________________________

    def test_vectorized_noreturn():
        x = m.NonPODClass(0)
        assert x.value == 0
        m.add_to(x, [1, 2, 3, 4])
>       assert x.value == 10
E       assert 4 == 10
E        +  where 4 = <pybind11_tests.numpy_vectorize.NonPODClass object at 0x7f737bc5def0>.value

x          = <pybind11_tests.numpy_vectorize.NonPODClass object at 0x7f737bc5def0>

../../tests/test_numpy_vectorize.py:264: AssertionError
=========================== short test summary info ============================
SKIPPED [1] ../../tests/test_builtin_casters.py:147: no <string_view>
SKIPPED [1] ../../tests/test_callbacks.py:220: Current PYBIND11_INTERNALS_VERSION too low
SKIPPED [1] ../../tests/test_copy_move.py:82: no <optional>
SKIPPED [1] ../../tests/test_eigen_matrix.py:753: could not import 'scipy': No module named 'scipy'
SKIPPED [1] ../../tests/test_eigen_matrix.py:763: could not import 'scipy': No module named 'scipy'
SKIPPED [1] ../../tests/test_pytypes.py:426: Not defined: PYBIND11_HANDLE_REF_DEBUG
SKIPPED [1] ../../tests/test_pytypes.py:1038: C++20 non-type template args feature not available.
SKIPPED [1] ../../tests/test_pytypes.py:1049: C++20 non-type template args feature not available.
SKIPPED [3] ../../tests/test_pytypes.py:1064: <ranges> not available.
SKIPPED [3] ../../tests/test_pytypes.py:1077: <ranges> not available.
SKIPPED [3] ../../tests/test_pytypes.py:1089: <ranges> not available.
SKIPPED [1] ../../tests/test_sequences_and_iterators.py:18: no <optional>
SKIPPED [1] ../../tests/test_stl.py:125: no <optional>
SKIPPED [1] ../../tests/test_stl.py:157: no <experimental/optional>
SKIPPED [1] ../../tests/test_stl.py:[189](https://github.com/pybind/pybind11/actions/runs/12301793335/job/34333160445?pr=3939#step:7:190): no <boost/optional>
SKIPPED [1] ../../tests/test_stl.py:248: no <filesystem>
SKIPPED [1] ../../tests/test_stl.py:315: no <variant>
SKIPPED [1] ../../tests/test_stl.py:332: no std::monostate
XFAIL ../../tests/test_unnamed_namespace_a.py::test_have_class_any_struct[None] - Known issues: https://github.com/pybind/pybind11/pull/4319
XFAIL ../../tests/test_unnamed_namespace_a.py::test_have_both_class_any_struct - Known issues: https://github.com/pybind/pybind11/pull/4319
XPASS ../../tests/test_unnamed_namespace_a.py::test_have_class_any_struct[unnamed_namespace_a_any_struct] Known issues: https://github.com/pybind/pybind11/pull/4319
FAILED ../../tests/test_numpy_dtypes.py::test_vectorize - AssertionError: 
Arrays are not equal

Mismatched elements: 2 / 3 (66.7%)
Max absolute difference: 20
Max relative difference: 1.
 x: array([0, 0, 0], dtype=uint32)
 y: array([ 0, 10, 20])
FAILED ../../tests/test_numpy_vectorize.py::test_vectorized_noreturn - assert 4 == 10
 +  where 4 = <pybind11_tests.numpy_vectorize.NonPODClass object at 0x7f737bc5def0>.value
======= 2 failed, 928 passed, 24 skipped, 2 xfailed, 1 xpassed in 17.31s =======

@rwgk
Copy link
Collaborator Author

rwgk commented Dec 12, 2024

This was the last time the "🐍 3 • Clang dev • C++11 • x64" job succeeded:

2024-12-09T18:24:26.5702743Z ##[command]/usr/bin/docker pull silkeh/clang:dev
2024-12-09T18:24:27.0106262Z dev: Pulling from silkeh/clang
2024-12-09T18:24:27.0107558Z bc0965b23a04: Pulling fs layer
2024-12-09T18:24:27.0108600Z 6da938ad37e9: Pulling fs layer
2024-12-09T18:24:27.0109666Z 7475a0ea1e5b: Pulling fs layer
2024-12-09T18:24:27.2804388Z bc0965b23a04: Verifying Checksum
2024-12-09T18:24:27.2805717Z bc0965b23a04: Download complete
2024-12-09T18:24:27.9422202Z 6da938ad37e9: Verifying Checksum
2024-12-09T18:24:27.9431455Z 6da938ad37e9: Download complete
2024-12-09T18:24:28.4965974Z bc0965b23a04: Pull complete
2024-12-09T18:24:32.4704837Z 7475a0ea1e5b: Verifying Checksum
2024-12-09T18:24:32.4705792Z 7475a0ea1e5b: Download complete
2024-12-09T18:24:32.5860868Z 6da938ad37e9: Pull complete
2024-12-09T18:24:40.6628204Z 7475a0ea1e5b: Pull complete
2024-12-09T18:24:40.6662474Z Digest: sha256:e0eb29fc737ac95a09bc3fbf91e6f2f01f52cc9cca06d05a7f39c2316bd8fa42
2024-12-09T18:24:40.6674926Z Status: Downloaded newer image for silkeh/clang:dev
2024-12-09T18:24:48.7208008Z -- The CXX compiler identification is Clang 20.0.0
2024-12-09T18:24:48.7445396Z -- Detecting CXX compiler ABI info
2024-12-09T18:24:48.8936937Z -- Detecting CXX compiler ABI info - done
2024-12-09T18:24:48.9001841Z -- Check for working CXX compiler: /usr/bin/c++ - skipped
2024-12-09T18:24:48.9005587Z -- Detecting CXX compile features
2024-12-09T18:24:48.9010993Z -- Detecting CXX compile features - done
2024-12-09T18:24:48.9039873Z -- pybind11 v2.14.0 dev1
2024-12-09T18:24:48.9040288Z -- CMake 3.25.1
2024-12-09T18:24:49.0898620Z -- Found Python: /usr/bin/python3 (found suitable version "3.11.2", minimum required is "3.8") found components: Interpreter Development.Module Development.Embed 
2024-12-09T18:24:49.0905810Z -- Python 3.11.2
2024-12-09T18:24:49.1166159Z -- Performing Test HAS_FLTO_THIN
2024-12-09T18:24:49.2888954Z -- Performing Test HAS_FLTO_THIN - Success
2024-12-09T18:24:49.2895255Z -- pybind11::lto enabled
2024-12-09T18:24:49.2895634Z -- pybind11::thin_lto enabled
2024-12-09T18:24:49.2923067Z -- Setting tests build type to MinSizeRel as none was specified
2024-12-09T18:24:49.2954394Z -- Building tests with Eigen v3.4.0
2024-12-09T18:24:49.3212555Z -- Could NOT find Boost (missing: Boost_INCLUDE_DIR) (Required is at least version "1.56")
2024-12-09T18:24:49.3743772Z -- Found pytest 7.2.1
2024-12-09T18:24:49.3761231Z -- Downloading catch v2.13.9...
2024-12-09T18:24:49.6805468Z -- Building interpreter tests using Catch v2.13.9
2024-12-09T18:24:49.6813582Z -- Performing Test CMAKE_HAVE_LIBC_PTHREAD
2024-12-09T18:24:49.8408510Z -- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Success
2024-12-09T18:24:49.8419565Z -- Found Threads: TRUE  
2024-12-09T18:24:49.8467684Z -- Configuring done
2024-12-09T18:24:49.8916861Z -- Generating done
2024-12-09T18:24:49.8954356Z -- Build files have been written to: /__w/pybind11/pybind11/build

@rwgk
Copy link
Collaborator Author

rwgk commented Dec 12, 2024

Docker info in the current log of the "🐍 3 • Clang dev • C++11 • x64" job:

2024-12-12T17:39:01.2415101Z ##[command]/usr/bin/docker pull silkeh/clang:dev
2024-12-12T17:39:02.1116711Z dev: Pulling from silkeh/clang
2024-12-12T17:39:02.1122161Z bc0965b23a04: Pulling fs layer
2024-12-12T17:39:02.1123056Z c62c0f870617: Pulling fs layer
2024-12-12T17:39:02.1123616Z 64d429ac581d: Pulling fs layer
2024-12-12T17:39:02.8944956Z bc0965b23a04: Download complete
2024-12-12T17:39:03.4914267Z c62c0f870617: Verifying Checksum
2024-12-12T17:39:03.4915516Z c62c0f870617: Download complete
2024-12-12T17:39:04.0348550Z bc0965b23a04: Pull complete
2024-12-12T17:39:05.9996607Z 64d429ac581d: Verifying Checksum
2024-12-12T17:39:05.9997141Z 64d429ac581d: Download complete
2024-12-12T17:39:07.8593764Z c62c0f870617: Pull complete
2024-12-12T17:39:15.7962202Z 64d429ac581d: Pull complete
2024-12-12T17:39:15.8002252Z Digest: sha256:f805f36ddfec36d85be07aa6d62442d55091eea113ef53043fba29a1794696c5
2024-12-12T17:39:15.8048562Z Status: Downloaded newer image for silkeh/clang:dev
2024-12-12T17:39:24.1767785Z -- The CXX compiler identification is Clang 20.0.0
2024-12-12T17:39:24.1995467Z -- Detecting CXX compiler ABI info
2024-12-12T17:39:24.3375093Z -- Detecting CXX compiler ABI info - done
2024-12-12T17:39:24.3440464Z -- Check for working CXX compiler: /usr/bin/c++ - skipped
2024-12-12T17:39:24.3444439Z -- Detecting CXX compile features
2024-12-12T17:39:24.3450660Z -- Detecting CXX compile features - done
2024-12-12T17:39:24.3478313Z -- pybind11 v2.14.0 dev1
2024-12-12T17:39:24.3478910Z -- CMake 3.25.1
2024-12-12T17:39:24.5102866Z -- Found Python: /usr/bin/python3 (found suitable version "3.11.2", minimum required is "3.8") found components: Interpreter Development.Module Development.Embed 
2024-12-12T17:39:24.5109208Z -- Python 3.11.2
2024-12-12T17:39:24.5390003Z -- Performing Test HAS_FLTO_THIN
2024-12-12T17:39:24.6941367Z -- Performing Test HAS_FLTO_THIN - Success
2024-12-12T17:39:24.6949608Z -- pybind11::lto enabled
2024-12-12T17:39:24.6949879Z -- pybind11::thin_lto enabled
2024-12-12T17:39:24.6974225Z -- Setting tests build type to MinSizeRel as none was specified
2024-12-12T17:39:24.7005456Z -- Building tests with Eigen v3.4.0
2024-12-12T17:39:24.7264275Z -- Could NOT find Boost (missing: Boost_INCLUDE_DIR) (Required is at least version "1.56")
2024-12-12T17:39:24.7789963Z -- Found pytest 7.2.1
2024-12-12T17:39:24.7807649Z -- Downloading catch v2.13.9...
2024-12-12T17:39:25.2990118Z -- Building interpreter tests using Catch v2.13.9
2024-12-12T17:39:25.2998450Z -- Performing Test CMAKE_HAVE_LIBC_PTHREAD
2024-12-12T17:39:25.4459419Z -- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Success
2024-12-12T17:39:25.4470083Z -- Found Threads: TRUE  
2024-12-12T17:39:25.4516399Z -- Configuring done
2024-12-12T17:39:25.4958742Z -- Generating done
2024-12-12T17:39:25.4997177Z -- Build files have been written to: /__w/pybind11/pybind11/build

This fails with: #5464 (comment)

The only change is the clang:dev docker container.

@rwgk rwgk changed the title WIP: clang dev Drop Clang dev CI job Dec 12, 2024
@rwgk
Copy link
Collaborator Author

rwgk commented Dec 12, 2024

For unknown reasons the "continuous-integration/appveyor/pr" job is stuck.

Ignoring.

This is definitely unrelated to the Clang dev removal.

@rwgk rwgk marked this pull request as ready for review December 12, 2024 19:14
@rwgk rwgk requested a review from henryiii as a code owner December 12, 2024 19:14
@rwgk rwgk merged commit 741d86f into pybind:master Dec 12, 2024
75 of 76 checks passed
@rwgk rwgk deleted the clang_dev branch December 12, 2024 19:15
@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label Dec 12, 2024
@rwgk rwgk removed the needs changelog Possibly needs a changelog entry label Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant