Fix Graphic Filled (0070,0024) validation condition
#116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #116 +/- ##
==========================================
+ Coverage 89.82% 89.95% +0.12%
==========================================
Files 15 15
Lines 1632 1672 +40
==========================================
+ Hits 1466 1504 +38
- Misses 166 168 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Thanks! Can you please also add an entry to the release notes (with a heading "Unreleased")?
drahoja9
force-pushed
the
fix/graphic-filled-condition
branch
2 times, most recently
from
673bb49 to
cf5d2e5
Compare
In case the parser would be able to correctly parse the `Graphic Filled` conditions, they should look something like this. What's missing is some operator describing the fact that the first and the last values should be equal.
for more information, see https://pre-commit.ci
drahoja9
force-pushed
the
fix/graphic-filled-condition
branch
from
cf5d2e5 to
fe3a43b
Compare
mrbean-bremen
approved these changes
Aug 4, 2024
|
Sure! Thank you for your swift feedback and merging the PR. 🤝 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #115