Partly fix parsing of Graphic Annotation condition #117
Conversation
- handle ", that is" phrase - handle mixed ORed values and conditions - catch incorrectly parsed value type - remove now unneeded special case
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #117 +/- ##
==========================================
+ Coverage 89.82% 89.98% +0.15%
==========================================
Files 15 15
Lines 1632 1697 +65
==========================================
+ Hits 1466 1527 +61
- Misses 166 170 +4 ☔ View full report in Codecov by Sentry. |
| @@ -246,15 +246,13 @@ def test_graphic_annotation_sequence(self, reader): | |||
| assert "(0070,0001)" in description | |||
| assert "items" in description["(0070,0001)"] | |||
|
|
|||
| graphic_object_sequence = "(0070,0009)" | |||
| compound_graphic_sequence = "(0070,0209)" | |||
| for sequence_tag in (graphic_object_sequence, compound_graphic_sequence): | |||
There was a problem hiding this comment.
(0070,0209) actually has another condition, so I removed in from the test. This is a problem with the SPECIAL_CASES mechanism, as it would change the condition for all occurrences of a tag.
There was a problem hiding this comment.
Ah, my mistake, I've looked it up briefly and did not check the attributes carefully, sorry.
|
Looks good to me. Thank you for the quick fix! |
@drahoja9 - please have a look. I reverted some of your changes, as the special handling is no longer needed, but let the mechanism in place.