Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some test consolidation #56

Merged
merged 1 commit into from
Oct 29, 2023

Conversation

mrbean-bremen
Copy link
Member

  • fixed possibility to run single tests
  • use full standard instead of fixture files for most tests
  • download and cache standard in the CI
  • fix to handle empty tag with type 1C as an error
  • use lxml used instead of xml for xml parsing

* fixed possibility to run single tests
* use full standard instead of fixture files for most tests
* download and cache standard in the CI
* fix to handle empty tag with type 1C as an error
* use lxml used instead of xml for xml parsing
@codecov-commenter
Copy link

codecov-commenter commented Oct 28, 2023

Codecov Report

Merging #56 (e163b5d) into main (90207ba) will increase coverage by 0.21%.
Report is 3 commits behind head on main.
The diff coverage is 71.42%.

@@            Coverage Diff             @@
##             main      #56      +/-   ##
==========================================
+ Coverage   88.71%   88.93%   +0.21%     
==========================================
  Files          14       14              
  Lines        1515     1518       +3     
==========================================
+ Hits         1344     1350       +6     
+ Misses        171      168       -3     
Files Coverage Δ
dicom_validator/spec_reader/edition_reader.py 98.45% <100.00%> (ø)
dicom_validator/validator/iod_validator.py 92.34% <100.00%> (-0.82%) ⬇️
dicom_validator/spec_reader/spec_reader.py 94.64% <50.00%> (+0.30%) ⬆️

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mrbean-bremen mrbean-bremen merged commit 988957a into pydicom:main Oct 29, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants