Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test with Python 3.13 #61

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Test with Python 3.13 #61

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ef67439
Test with Python 3.13
jan-janssen Jan 8, 2025
d580612
Merge pull request #63 from pyiron/main
jan-janssen Jan 8, 2025
1275c27
Merge branch 'main' into python313
jan-janssen Jan 23, 2025
506c0d5
Merge branch 'main' into python313
jan-janssen Feb 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions .github/workflows/unittests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,15 @@ jobs:
matrix:
include:
- operating-system: macos-latest
python-version: '3.12'
python-version: '3.13'

- operating-system: ubuntu-latest
python-version: '3.12'
python-version: '3.13'

- operating-system: windows-latest
python-version: '3.13'

Comment on lines +17 to +24
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Update Python version support metadata before adding 3.13 tests

The package metadata in pyproject.toml needs to be updated before adding Python 3.13 tests:

  • Add "Programming Language :: Python :: 3.13" to the classifiers
  • Verify that conda==24.11.2 and executorlib==0.0.7 support Python 3.13
  • Consider marking Python 3.13 jobs as experimental using continue-on-error: true
🔗 Analysis chain

Verify Python 3.13 compatibility and update documentation.

Adding Python 3.13 testing is forward-thinking, but since Python 3.13 is still in development:

  1. Ensure all dependencies support Python 3.13
  2. Document any known compatibility issues or limitations
  3. Consider marking these jobs as experimental/allowed to fail

Let's check the package compatibility:

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Check if Python package dependencies specify Python 3.13 support
for file in setup.py setup.cfg pyproject.toml; do
  if [ -f "$file" ]; then
    echo "=== $file ==="
    cat "$file"
  fi
done

Length of output: 1818

- operating-system: ubuntu-latest
python-version: '3.12'

- operating-system: ubuntu-latest
Expand Down Expand Up @@ -48,7 +51,7 @@ jobs:
run: |
pip install versioneer[toml]==0.29
pip install . --no-deps --no-build-isolation
conda create -y -n py312 python=3.12.1 conda=24.7.1 executorlib=0.0.5
conda create -y -n py312 python=3.12.1 conda=24.11.2 executorlib=0.0.7
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Critical: Fix Python version mismatch in Conda environment.

There are several issues with the Conda environment setup:

  1. The environment uses Python 3.12.1 while testing Python 3.13, which could lead to inconsistent results
  2. The environment creation happens after the main package installation
  3. The environment setup is duplicating the installation steps

Consider this alternative approach:

-        conda create -y -n py312 python=3.12.1 conda=24.11.2 executorlib=0.0.7
+        conda create -y -n pyenv python=${{ matrix.python-version }} conda=24.11.2 executorlib=0.0.7
-        conda activate py312
+        conda activate pyenv
         pip install versioneer[toml]==0.29
         pip install . --no-deps --no-build-isolation
         conda deactivate

Committable suggestion skipped: line range outside the PR's diff.

conda activate py312
pip install versioneer[toml]==0.29
pip install . --no-deps --no-build-isolation
Expand Down
Loading