Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[minor] Set cwd to None by default #1225

Merged
merged 4 commits into from
Nov 29, 2023
Merged

[minor] Set cwd to None by default #1225

merged 4 commits into from
Nov 29, 2023

Conversation

samwaseda
Copy link
Member

Based on the discussion here I bring back the default behaviour.

@samwaseda
Copy link
Member Author

I will merge this as soon as the tests pass

@samwaseda samwaseda added the format_black reformat the code using the black standard label Nov 29, 2023
@samwaseda samwaseda added format_black reformat the code using the black standard and removed format_black reformat the code using the black standard labels Nov 29, 2023
@coveralls
Copy link

coveralls commented Nov 29, 2023

Pull Request Test Coverage Report for Build 7038764514

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 37 of 38 (97.37%) changed or added relevant lines in 2 files are covered.
  • 42 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 68.767%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pyiron_atomistics/sphinx/output_parser.py 32 33 96.97%
Files with Coverage Reduction New Missed Lines %
pyiron_atomistics/atomistics/master/quasi.py 42 25.69%
Totals Coverage Status
Change from base Build 7029482535: 0.1%
Covered Lines: 10806
Relevant Lines: 15714

💛 - Coveralls

@samwaseda samwaseda added the integration Start the notebook integration tests for this PR label Nov 29, 2023
@samwaseda samwaseda merged commit bffc9d9 into main Nov 29, 2023
24 of 26 checks passed
@delete-merged-branch delete-merged-branch bot deleted the spx_parser_exception branch November 29, 2023 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
format_black reformat the code using the black standard integration Start the notebook integration tests for this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants