Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return dictionary for SPHInX log parser to be a full parser #1229

Merged
merged 15 commits into from
Nov 30, 2023
Merged

Return dictionary for SPHInX log parser to be a full parser #1229

merged 15 commits into from
Nov 30, 2023

Conversation

samwaseda
Copy link
Member

Today I had a discussion with @jan-janssen and we agreed on a general form of the function that we would like to use, so I implemented it here, also because I personally need it now for my own purpose.

@samwaseda samwaseda added format_black reformat the code using the black standard integration Start the notebook integration tests for this PR labels Nov 29, 2023
@samwaseda samwaseda added format_black reformat the code using the black standard and removed format_black reformat the code using the black standard labels Nov 30, 2023
@samwaseda samwaseda mentioned this pull request Nov 30, 2023
Merged
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7043702181

  • 41 of 44 (93.18%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.008%) to 68.775%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pyiron_atomistics/sphinx/base.py 10 11 90.91%
pyiron_atomistics/sphinx/output_parser.py 31 33 93.94%
Totals Coverage Status
Change from base Build 7039015668: 0.008%
Covered Lines: 10810
Relevant Lines: 15718
💛 - Coveralls

@samwaseda samwaseda merged commit a3db70f into main Nov 30, 2023
22 of 23 checks passed
@delete-merged-branch delete-merged-branch bot deleted the spx_parser_return_dict branch November 30, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
format_black reformat the code using the black standard integration Start the notebook integration tests for this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@samwaseda @coveralls @pyiron-runner