Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clears output for restarted jobs #1549

Merged
merged 8 commits into from
Aug 28, 2024
Merged

clears output for restarted jobs #1549

merged 8 commits into from
Aug 28, 2024

Conversation

skatnagallu
Copy link
Contributor

Temporary fix for the issue mentioned in pyiron base.

This is a temporary solution.

@coveralls
Copy link

coveralls commented Aug 28, 2024

Pull Request Test Coverage Report for Build 10598107093

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 9 of 10 (90.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.005%) to 70.939%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pyiron_atomistics/sphinx/base.py 9 10 90.0%
Files with Coverage Reduction New Missed Lines %
pyiron_atomistics/sphinx/base.py 1 80.06%
Totals Coverage Status
Change from base Build 10575355657: 0.005%
Covered Lines: 10687
Relevant Lines: 15065

💛 - Coveralls

@skatnagallu skatnagallu requested a review from freyso August 28, 2024 07:35
@@ -2151,6 +2153,13 @@ def from_hdf(self, hdf):
self.old_version = True
pass

def clear_output_for_restart(self):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you call the same clear_output_for_restart() function in the __init__() function of the Output class? This hopefully prevents us from changing both independent from each other.

@freyso
Copy link
Contributor

freyso commented Aug 28, 2024

What about simply calling the function clear or setup_fresh or something like this?
I find it confusing for newcomers to see a function clear_output_for_restart in an __init__ function. It might also be advantageous to keep the function once the output copying issue is fixed, in case one would like to redo the output parsing and ensure that no unexpected items are left in (say: if we discover additional parsing bugs and want to redo the parsing for an existing expensive calculation).

pyiron_atomistics/sphinx/base.py Show resolved Hide resolved
pyiron_atomistics/sphinx/base.py Outdated Show resolved Hide resolved
@jan-janssen jan-janssen requested a review from samwaseda August 28, 2024 12:07
Copy link
Member

@jan-janssen jan-janssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, still I would like @samwaseda to take a quick look as he is currently the maintainer of the Sphinx interface in pyiron.

Copy link
Member

@samwaseda samwaseda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me.

@freyso
Copy link
Contributor

freyso commented Aug 28, 2024

fine for me.

@pmrv pmrv merged commit b8cb774 into main Aug 28, 2024
21 of 22 checks passed
@pmrv pmrv deleted the clear_output_sphinx branch August 28, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants