-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clears output for restarted jobs #1549
Conversation
for more information, see https://pre-commit.ci
Pull Request Test Coverage Report for Build 10598107093Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
pyiron_atomistics/sphinx/base.py
Outdated
@@ -2151,6 +2153,13 @@ def from_hdf(self, hdf): | |||
self.old_version = True | |||
pass | |||
|
|||
def clear_output_for_restart(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you call the same clear_output_for_restart()
function in the __init__()
function of the Output class? This hopefully prevents us from changing both independent from each other.
Co-authored-by: Jan Janssen <[email protected]>
What about simply calling the function |
Co-authored-by: freyso <[email protected]>
Co-authored-by: freyso <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, still I would like @samwaseda to take a quick look as he is currently the maintainer of the Sphinx interface in pyiron.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine by me.
fine for me. |
Temporary fix for the issue mentioned in pyiron base.
This is a temporary solution.