Fix to stop convergence checks for interactive jobs!

[sudarsan-surendralal]

A temporary fix! Please feel free to modify this if necessary

[coveralls]

Pull Request Test Coverage Report for Build 914266187

• 3 of 4 (75.0%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.002%) to 67.643%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pyiron_atomistics/vasp/interactive.py	3	4	75.0%

Totals
Change from base Build 909017515:	0.002%
Covered Lines:	10666
Relevant Lines:	15768

---

💛 - Coveralls

[pmrv]

We could also put this into GenericInteractive, no?

[liamhuber]

We could also put this into GenericInteractive, no?

If I understand, then we rely entirely on the MRO and if anyone switched class VaspInteractive(VaspBase, GenericInteractive) to class VaspInteractive(GenericInteractive, VaspBase) we would break the functionality because of all the funky convergence check jazz in VaspBase. (Or it starts backwards and we would need to do this now? Honestly I can never remember the order of resolution.) I think it's unlikely that someone would go around messing with the inheritance structure without knowing what they're doing/having a good reason, but it still seems like it adds unnecessary fragility.

[liamhuber]

In the long run we need to adjust the inheritance tree so this sort of awkwardness is not necessary, but in the short run I don't see any problems or have any better suggestions!

[pmrv]

We could also put this into GenericInteractive, no?

If I understand, then we rely entirely on the MRO and if anyone switched class VaspInteractive(VaspBase, GenericInteractive) to class VaspInteractive(GenericInteractive, VaspBase) we would break the functionality because of all the funky convergence check jazz in VaspBase. (Or it starts backwards and we would need to do this now? Honestly I can never remember the order of resolution.) I think it's unlikely that someone would go around messing with the inheritance structure without knowing what they're doing/having a good reason, but it still seems like it adds unnecessary fragility.

Works for me, just wanted to raise the point.

[liamhuber]

Works for me, just wanted to raise the point.

It was a good one. I'm 100% behind the principle of pushing the method as far upstream as it still makes sense (and it really makes sense in GenericInteractive, it's just that here the streams get too crossed 😝