-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move recursive loading of DataContainer to HDF5Content #1391
Conversation
This will allow users and internal code to use job.content[...] if they what they are looking for is saved in HDF5 storage and obviate the need to rely on job[...] which may be slow because it is also searching the compressed job files. I will need some logic like this to fix the slow loading of pyiron_atomistics jobs.
old name made no sense
The last commit should actually fix pyiron/pyiron_atomistics#1348 and pyiron/pyiron_atomistics#1350, but I'll probably add them in anyway for cleanliness. As of this PR one can access various things in a job like this:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Still we should think about adding a benchmark which times typical job[item]
queries and make sure we do not merge changes in the future which slow down.
This will allow users and internal code to use job.content[...] if they what they are looking for is saved in HDF5 storage and obviate the need to rely on job[...] which may be slow because it is also searching the compressed job files.
I will need some logic like this to fix the slow loading of pyiron_atomistics jobs.