-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[patch] Remove redundant conversion of project name #1543
Conversation
Can we add unit tests for the |
There are already unit tests and right now I'm not adding new functionalities. When I come to the point where I start adding something I'll add unit tests. |
I added assertion tests in the code, because I just don't understand what kind of situation was imagined previously. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Co-authored-by: Jan Janssen <[email protected]>
Trying to make smaller PRs to make this PR lighter. I guess this one is a small patch