Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[patch] Remove redundant conversion of project name #1543

Merged
merged 11 commits into from
Jul 20, 2024
Merged

Conversation

samwaseda
Copy link
Member

Trying to make smaller PRs to make this PR lighter. I guess this one is a small patch

@samwaseda samwaseda added the patch backward compatible bug fixes label Jul 19, 2024
@samwaseda samwaseda requested a review from jan-janssen July 19, 2024 12:57
@jan-janssen
Copy link
Member

Can we add unit tests for the pack() and unpack() to make sure we get it right this time.

@samwaseda
Copy link
Member Author

Can we add unit tests for the pack() and unpack() to make sure we get it right this time.

There are already unit tests and right now I'm not adding new functionalities. When I come to the point where I start adding something I'll add unit tests.

@samwaseda
Copy link
Member Author

Can we add unit tests for the pack() and unpack() to make sure we get it right this time.

I added assertion tests in the code, because I just don't understand what kind of situation was imagined previously.

Copy link
Member

@jan-janssen jan-janssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@samwaseda samwaseda merged commit 7b03591 into main Jul 20, 2024
26 checks passed
@samwaseda samwaseda deleted the convert_name branch July 20, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch backward compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants