-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[patch] replace logger with snippets version #1073
Conversation
Notebook failure:
This is completely unrelated, it's not even our deprecator that's failing, nor even our call. At first glance it looks like pymatgen has an internal inconsistency. |
Pull Request Test Coverage Report for Build 9371084055Details
💛 - Coveralls |
Ok, pinning pymatgen to the penultimate release does the trick, but as discussed in #1074 this is not my favourite solution |
Ugh. I guess pinning pymatgen got us a different version of pyiron_atomistics than we wanted. I am not able to dig into this immediately. |
I think it got us the correct version, but the import error there originates from #1040 where @jan-janssen forgot to update the import paths in the tests. I'll fix it in a separate PR, but it made me realize that we don't actually specify the version of |
i.e. pyiron_base.state.logger.logger with pyiron_snippets.logger.logger. The original location leaves a re-direct for backwards compatibility.
i.e. pyiron_base.state.logger.logger with pyiron_snippets.logger.logger. The original location leaves a re-direct for backwards compatibility.