Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make database optional #123

Merged
merged 5 commits into from
Jan 25, 2025
Merged

Make database optional #123

merged 5 commits into from
Jan 25, 2025

Conversation

samwaseda
Copy link
Member

I'm currently trying to use hash based nodes in my knowledge graph nodes and since I can make sense of the functionalities from hash_based_storage.py but without database, I make the database part optional. Thanks for the info to @jan-janssen

Copy link

Binder 👈 Launch a binder notebook on branch pyiron/pyiron_nodes/optional_db

Copy link

codacy-production bot commented Jan 25, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+1.62% (target: -1.00%) 4.20%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (bb4a4c8) 2187 654 29.90%
Head commit (d71e4d4) 2192 (+5) 691 (+37) 31.52% (+1.62%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#123) 143 6 4.20%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@coveralls
Copy link

coveralls commented Jan 25, 2025

Pull Request Test Coverage Report for Build 12964918777

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 402 unchanged lines in 18 files lost coverage.
  • Overall coverage increased (+1.6%) to 31.524%

Files with Coverage Reduction New Missed Lines %
atomistic/structure/build.py 3 33.33%
continuum_fem/load_definitions/poisson_load_expr.py 3 0.0%
continuum_fem/geometries/two_d_geometries.py 4 0.0%
continuum_fem/solvers/poisson_equations.py 5 0.0%
large_scale_atomistic/structure/boundary_layers.py 6 0.0%
large_scale_atomistic/structure/k_controlled_cracks.py 6 0.0%
continuum_fem/function_spaces/general_function_spaces.py 7 0.0%
continuum_fem/geometries/three_d_geometries.py 9 0.0%
large_scale_atomistic/structure/visualize_structures.py 10 0.0%
continuum_fem/custom_nodes/custom_plots.py 12 0.0%
Totals Coverage Status
Change from base Build 12959156543: 1.6%
Covered Lines: 691
Relevant Lines: 2192

💛 - Coveralls

@samwaseda samwaseda mentioned this pull request Jan 25, 2025
@samwaseda samwaseda merged commit 3647ebf into main Jan 25, 2025
16 checks passed
@samwaseda samwaseda deleted the optional_db branch January 25, 2025 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants