Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Resolvers to unify finding of resources #20

Merged
merged 7 commits into from
Jul 15, 2024
Merged

Add Resolvers to unify finding of resources #20

merged 7 commits into from
Jul 15, 2024

Conversation

pmrv
Copy link
Contributor

@pmrv pmrv commented Jul 9, 2024

Add two classes to find files in pyiron resource paths, one for any resource files one specifically for executables that also parses out versions.

Copy link

github-actions bot commented Jul 9, 2024

Binder 👈 Launch a binder notebook on branch pyiron/pyiron_snippets/resources

Copy link

codacy-production bot commented Jul 9, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.23% (target: -1.00%) 95.96%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (553d8d4) 451 427 94.68%
Head commit (cdc9123) 550 (+99) 522 (+95) 94.91% (+0.23%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#20) 99 95 95.96%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences


🚀 Don’t miss a bit, follow what’s new on Codacy.

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@coveralls
Copy link

coveralls commented Jul 9, 2024

Pull Request Test Coverage Report for Build 9940824536

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 94.909%

Totals Coverage Status
Change from base Build 9585394448: 0.2%
Covered Lines: 522
Relevant Lines: 550

💛 - Coveralls

pmrv and others added 3 commits July 10, 2024 09:51
Add two classes to find files in pyiron resource paths, one for any resource files
one specifically for executables that also parses out versions.
@pmrv pmrv added the format_black Trigger the black formatting bot label Jul 10, 2024
@pmrv pmrv added format_black Trigger the black formatting bot and removed format_black Trigger the black formatting bot labels Jul 15, 2024
Copy link
Member

@jan-janssen jan-janssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@pmrv pmrv merged commit 7a4fe2a into main Jul 15, 2024
19 checks passed
@pmrv pmrv deleted the resources branch July 15, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
format_black Trigger the black formatting bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants