[patch] Allow _FactoryMade
to explicitly define where its reduce should import from
#27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a
@classfactory
is used inside a decorator, i.e. to create a new class directly from a decorated function or class definition, the new_FactoryMade
class automatically conflicts with the namespace of its underlying source material. Previously, you could store the underlying function with_class_returns_from_decorated_function
to avoid this conflict. This PR deprecates (but leaves available) that interface, while providing a new_reduce_imports_as: tuple[str, str]
allowing you to explicitly specify where the_FactoryMade
class should be (re)imported from in__reduce__
. IMO this is a bit clearer, and is necessary flexibility for pyiron/pyiron_workflow#410 which is closing pyiron/pyiron_workflow#319.