Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix repr of Resolvers #29

Merged
merged 1 commit into from
Aug 23, 2024
Merged

Fix repr of Resolvers #29

merged 1 commit into from
Aug 23, 2024

Conversation

pmrv
Copy link
Contributor

@pmrv pmrv commented Aug 23, 2024

There is a "," missing between module and subdirs in the ResourceResolver.__repr__.

Copy link

Binder 👈 Launch a binder notebook on branch pyiron/pyiron_snippets/repr

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.17% (target: -1.00%) 50.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (e0beaa6) 559 532 95.17%
Head commit (10c3e00) 560 (+1) 532 (+0) 95.00% (-0.17%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#29) 2 1 50.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10528369536

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 95.0%

Files with Coverage Reduction New Missed Lines %
resources.py 1 95.28%
Totals Coverage Status
Change from base Build 10295570410: -0.2%
Covered Lines: 532
Relevant Lines: 560

💛 - Coveralls

Copy link
Member

@liamhuber liamhuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep

@pmrv pmrv merged commit 731bb74 into main Aug 23, 2024
20 checks passed
@pmrv pmrv deleted the repr branch August 23, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants