-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make DirectoryObject recognize various init variables #216
Conversation
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesYou may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation |
Pull Request Test Coverage Report for Build 7970400900Details
💛 - Coveralls |
@liamhuber I made this project to make a better overview. Hopefully it helps a bit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing a test case, but otherwise lgtm
@@ -10,6 +10,12 @@ def setUp(cls): | |||
def tearDown(cls): | |||
cls.directory.delete() | |||
|
|||
def test_directory_instantiation(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing the case of instantiation by string
Since the distinction won't be needed if |
I think it's straightforward enough, but this PR is to make
DirectoryObject
recognisestr
,Path
andDirectoryObject
for the directory instantiation.I guess this is the first one to be merged. Sorry for going back and forth all the time!