-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mp-api interface #91
Draft
jan-janssen
wants to merge
4
commits into
main
Choose a base branch
from
mp-api
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,171 @@ | ||
from typing import Union, List | ||
from ase.atoms import Atoms | ||
from structuretoolkit.common.pymatgen import pymatgen_to_ase | ||
|
||
|
||
class MPQueryResults: | ||
def __init__(self, results): | ||
""" | ||
|
||
Args: | ||
docs (list of dicts): query results from Materials Project, should be obtained with use_document_model=False | ||
""" | ||
self._results = results | ||
self._material_ids = [r["material_id"] for r in results] | ||
|
||
def _translate_frame(self, frame): | ||
try: | ||
return self._material_ids.index(frame) | ||
except ValueError: | ||
raise KeyError(f"material id {frame} not among results!") from None | ||
|
||
def __iter__(self): | ||
yield from self.iter_structures() | ||
|
||
def _get_structure(self, frame, wrap_atoms=True): | ||
return pymatgen_to_ase(self._results[frame]["structure"]) | ||
|
||
def _number_of_structures(self): | ||
return len(self._results) | ||
|
||
def to_list(self): | ||
""" | ||
Get a list of queried structures. | ||
|
||
Returns: | ||
list: structures | ||
""" | ||
return [pymatgen_to_ase(r["structure"]) for r in self._results] | ||
|
||
|
||
class MaterialsProject: | ||
""" | ||
Convenience interface to the Materials Project Structure Database. | ||
|
||
Usage is only possible with an API key obtained from the Materials Project. To do this, create an account with | ||
them, login and access `this webpage <https://next-gen.materialsproject.org/api#api-key>`. | ||
|
||
Once you have a key, either pass it as the `api_key` parameter in the methods of this object or export an | ||
environment variable, called `MP_API_KEY`, in your shell setup. | ||
""" | ||
|
||
@staticmethod | ||
def search( | ||
chemsys: Union[str, List[str]], api_key=None, **kwargs | ||
) -> MPQueryResults: | ||
""" | ||
Search the database for all structures matching the given query. | ||
|
||
Note that `chemsys` takes distint values for unaries, binaries and so! A query with `chemsys=["Fe", "O"]` will | ||
return iron structures and oxygen structures, but no iron oxide structures. Similarily `chemsys=["Fe-O"]` will | ||
not return unary structures. | ||
|
||
All keyword arguments for filtering from the original API are supported. See the | ||
`original docs <https://docs.materialsproject.org/downloading-data/using-the-api>`_ for them. | ||
|
||
Search for all iron structures: | ||
|
||
>>> pr = Project(...) | ||
>>> irons = pr.create.structure.materialsproject.search("Fe") | ||
>>> irons.number_of_structures | ||
10 | ||
|
||
The returned :class:`~.MPQueryResults` object implements :class:`~.HasStructure` and can be accessed with the | ||
material ids as a short-hand | ||
|
||
>>> irons.get_structure(1) == irons.get_structure('mp-13') | ||
True | ||
|
||
Search for all structures with Al, Li that are on the T=0 convex hull: | ||
|
||
>>> alli = pr.create.structure.materialsproject.search(['Al', 'Li', 'Al-Li'], is_stable=True) | ||
>>> len(alli) | ||
6 | ||
|
||
Args: | ||
chemsys (str, list of str): confine search to given elements; either an element symbol or multiple element | ||
symbols seperated by dashes; if a list of strings is given return structures matching either of them | ||
api_key (str, optional): if your API key is not exported in the environment flag MP_API_KEY, pass it here | ||
**kwargs: passed verbatim to :meth:`mp_api.MPRester.summary.search` to further filter the results | ||
|
||
Returns: | ||
:class:`~.MPQueryResults`: resulting structures from the query | ||
""" | ||
from mp_api.client import MPRester | ||
|
||
rest_kwargs = { | ||
"use_document_model": False, # returns results as dictionaries | ||
"include_user_agent": True, # send some additional software version info to MP | ||
} | ||
if api_key is not None: | ||
rest_kwargs["api_key"] = api_key | ||
with MPRester(**rest_kwargs) as mpr: | ||
results = mpr.summary.search( | ||
chemsys=chemsys, **kwargs, fields=["structure", "material_id"] | ||
) | ||
return MPQueryResults(results) | ||
|
||
@staticmethod | ||
def by_id( | ||
material_id: Union[str, int], | ||
final: bool = True, | ||
conventional_unit_cell: bool = False, | ||
api_key=None, | ||
) -> Union[Atoms, List[Atoms]]: | ||
""" | ||
Retrieve a structure by material id. | ||
|
||
This is how you would ask for the iron ground state: | ||
|
||
>>> pr = Project(...) | ||
>>> pr.create.structure.materialsproject.by_id('mp-13') | ||
Fe: [0. 0. 0.] | ||
tags: | ||
spin: [(0: 2.214)] | ||
pbc: [ True True True] | ||
cell: | ||
Cell([[2.318956, 0.000185, -0.819712], [-1.159251, 2.008215, -0.819524], [2.5e-05, 0.000273, 2.459206]]) | ||
|
||
|
||
Args: | ||
material_id (str): the id assigned to a structure by the materials project | ||
api_key (str, optional): if your API key is not exported in the environment flag MP_API_KEY, pass it here | ||
final (bool, optional): if set to False, returns the list of initial structures, | ||
else returns the final structure. (Default is True) | ||
conventional_unit_cell (bool, optional): if set to True, returns the standard conventional unit cell. | ||
(Default is False) | ||
|
||
Returns: | ||
:class:`~.Atoms`: requested final structure if final is True | ||
list of :class:~.Atoms`: a list of initial (pre-relaxation) structures if final is False | ||
|
||
Raises: | ||
ValueError: material id does not exist | ||
""" | ||
from mp_api.client import MPRester | ||
|
||
rest_kwargs = { | ||
"include_user_agent": True, # send some additional software version info to MP | ||
} | ||
if api_key is not None: | ||
rest_kwargs["api_key"] = api_key | ||
with MPRester(**rest_kwargs) as mpr: | ||
if final: | ||
return pymatgen_to_ase( | ||
mpr.get_structure_by_material_id( | ||
material_id=material_id, | ||
final=final, | ||
conventional_unit_cell=conventional_unit_cell, | ||
) | ||
) | ||
else: | ||
return [ | ||
pymatgen_to_ase(mpr_structure) | ||
for mpr_structure in ( | ||
mpr.get_structure_by_material_id( | ||
material_id=material_id, | ||
final=final, | ||
conventional_unit_cell=conventional_unit_cell, | ||
) | ||
) | ||
] |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This class really only works with the
HasStructure
interface frompyiron_atomistics
. Since we don't have that here, it might be better to replace it completely with just lists of dictionaries.