Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Implementing Adorn Functions #1439

Open
wants to merge 8 commits into
base: dev
Choose a base branch
from

Conversation

Sarra99
Copy link

@Sarra99 Sarra99 commented Jan 24, 2025

This PR resolves #993.

PR Checklist

Please ensure that you have done the following:

  1. PR in from a fork off your branch. Do not PR from <your_username>:dev, but rather from <your_username>:<feature-branch_name>.
  1. If you're not on the contributors list, add yourself to AUTHORS.md.
  1. Add a line to CHANGELOG.md under the latest version header (i.e. the one that is "on deck") describing the contribution.
    • Do use some discretion here; if there are multiple PRs that are related, keep them in a single line.

Automatic checks

There will be automatic checks run on the PR. These include:

  • Building a preview of the docs on Netlify
  • Automatically linting the code
  • Making sure the code is documented
  • Making sure that all tests are passed
  • Making sure that code coverage doesn't go down.

Relevant Reviewers

Please tag maintainers to review.

Copy link

codecov bot commented Jan 25, 2025

Codecov Report

Attention: Patch coverage is 95.71429% with 3 lines in your changes missing coverage. Please review.

Project coverage is 83.37%. Comparing base (6e77fbc) to head (97e786b).
Report is 45 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1439      +/-   ##
==========================================
- Coverage   89.07%   83.37%   -5.70%     
==========================================
  Files          87       88       +1     
  Lines        5374     6444    +1070     
==========================================
+ Hits         4787     5373     +586     
- Misses        587     1071     +484     

@samukweku
Copy link
Collaborator

@Sarra99 kudos on your PR!!
kindly add more tests to ensure coverage is complete. The code shows the missing lines in your code that do not have coverage.

Thanks!!

Copy link
Collaborator

@samukweku samukweku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pinging @ericmjl and @pyjanitor-devs/core-devs

@Sarra99 Sarra99 force-pushed the SarraNEBLI/adorn_functions branch from 4b1ff87 to add19e9 Compare January 28, 2025 09:48
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sarra99 would you be kind enough to decorate the functions here as a dataframe method, like we do in other files?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENH] adorn functions
3 participants