Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nan safety #31

Merged
merged 7 commits into from
Jun 23, 2024
Merged

Nan safety #31

merged 7 commits into from
Jun 23, 2024

Conversation

Ipuch
Copy link
Collaborator

@Ipuch Ipuch commented Jun 22, 2024

This change is Reviewable

@@ -190,9 +190,11 @@ def add_video(self, name, video_array: np.ndarray) -> None:

self.xp_data.add_data(Video(name=f"{self.name}/{name}", video_array=video_array))

def rerun(self, name: str = "animation_phase", init: bool = True, clear_last_node: bool = False) -> None:
def rerun(
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function rerun has 5 arguments (exceeds 4 allowed). Consider refactoring.

Copy link

codeclimate bot commented Jun 23, 2024

Code Climate has analyzed commit b7ef6fb and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

View more on Code Climate.

@Ipuch Ipuch merged commit b83da89 into pyomeca:main Jun 23, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant