feat: better per svm docs #536
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
guibescos
reviewed
Dec 17, 2024
|
|
||
| ```typescript | ||
| import { Client, Opportunity } from "@pythnetwork/express-relay-js"; | ||
|
|
||
| latestChainUpdate: Record<string, SvmChainUpdate> = {} |
There was a problem hiding this comment.
Suggested change
| latestChainUpdate: Record<string, SvmChainUpdate> = {} | |
| const latestChainUpdate: Record<ChainId, SvmChainUpdate> = {} |
guibescos
reviewed
Dec 17, 2024
|
|
||
| <Tabs.Tab> | ||
| Pyth provides a Typescript SDK, which allows searchers to subscribe to opportunities: | ||
|
|
||
| ```typescript | ||
| import { Client, Opportunity } from "@pythnetwork/express-relay-js"; |
There was a problem hiding this comment.
Suggested change
| import { Client, Opportunity } from "@pythnetwork/express-relay-js"; | |
| import { ChainId, Client, Opportunity } from "@pythnetwork/express-relay-js"; |
guibescos
reviewed
Dec 17, 2024
| get back \$1000. | ||
| </Callout> | ||
|
|
||
| The auction server also broadcast chain specific information that are necessary for building the transaction: |
There was a problem hiding this comment.
Suggested change
| The auction server also broadcast chain specific information that are necessary for building the transaction: | |
| The auction server also broadcasts chain specific information that is necessary for building the transaction: |
guibescos
reviewed
Dec 17, 2024
| @@ -189,7 +249,7 @@ from solders.transaction import Transaction | |||
| from express_relay.models.svm import BidSvm | |||
| from express_relay.svm.limo_client import OrderStateAndAddress | |||
|
|
|||
| DEADLINE = 2**62 | |||
| DEADLINE = 2 * 10**10 | |||
guibescos
reviewed
Dec 17, 2024
| - It should contain an instruction to set the [transaction priority fee](https://solana.com/developers/guides/advanced/how-to-use-priority-fees#what-are-priority-fees). The priority fee should be at least as large the amount | ||
| advertised via websocket. | ||
| - It should contain valid signatures for all signers except the relayer | ||
| - It should pass simulation |
There was a problem hiding this comment.
Suggested change
| - It should pass simulation | |
| - It should pass simulation. |
guibescos
reviewed
Dec 17, 2024
| - The deadline specified in the `SubmitBid` instruction should be at least 5 seconds in the future. | ||
| - It should contain an instruction to set the [transaction priority fee](https://solana.com/developers/guides/advanced/how-to-use-priority-fees#what-are-priority-fees). The priority fee should be at least as large the amount | ||
| advertised via websocket. | ||
| - It should contain valid signatures for all signers except the relayer |
There was a problem hiding this comment.
Suggested change
| - It should contain valid signatures for all signers except the relayer | |
| - It should contain valid signatures for all signers except the relayer. |
guibescos
reviewed
Dec 17, 2024
|
|
||
| </Tabs> | ||
|
|
||
| The schema for the opportunity is similar to what’s returned in the [HTTP requests](https://pyth-express-relay-mainnet.asymmetric.re/docs#tag/opportunity/operation/get_opportunities) |
There was a problem hiding this comment.
Suggested change
| The schema for the opportunity is similar to what’s returned in the [HTTP requests](https://pyth-express-relay-mainnet.asymmetric.re/docs#tag/opportunity/operation/get_opportunities) | |
| The schema for the opportunity is similar to what’s returned in the [HTTP requests](https://pyth-express-relay-mainnet.asymmetric.re/docs#tag/opportunity/operation/get_opportunities). |
guibescos
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Include more information on how svm bids are validated and the chain update messages received in websocket.
Type of Change
Areas Affected
Express Relay Searcher integration
Checklist
pre-commit run --all-filesto check for linting errorsRelated Issues
Closes #
Additional Notes
Contributor Information
Screenshots