Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make seconds optional in parse_time time formats #1141

Merged
merged 1 commit into from
Oct 20, 2024

Conversation

tomasr8
Copy link
Member

@tomasr8 tomasr8 commented Oct 19, 2024

This addresses the crash by making the seconds optional. If the time format only contains hours and minutes, seconds are assumed to be zero.

closes #1129

Copy link

codecov bot commented Oct 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.32%. Comparing base (f1c8633) to head (315fdcc).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1141   +/-   ##
=======================================
  Coverage   91.31%   91.32%           
=======================================
  Files          27       27           
  Lines        4618     4620    +2     
=======================================
+ Hits         4217     4219    +2     
  Misses        401      401           
Flag Coverage Δ
macos-12-3.10 90.08% <100.00%> (+<0.01%) ⬆️
macos-12-3.11 90.02% <100.00%> (+<0.01%) ⬆️
macos-12-3.12 90.23% <100.00%> (+<0.01%) ⬆️
macos-12-3.13-dev 89.76% <100.00%> (+<0.01%) ⬆️
macos-12-3.8 90.01% <100.00%> (+<0.01%) ⬆️
macos-12-3.9 90.01% <100.00%> (+<0.01%) ⬆️
macos-12-pypy3.10 90.08% <100.00%> (+<0.01%) ⬆️
ubuntu-22.04-3.10 90.10% <100.00%> (+<0.01%) ⬆️
ubuntu-22.04-3.11 90.04% <100.00%> (+<0.01%) ⬆️
ubuntu-22.04-3.12 90.25% <100.00%> (+<0.01%) ⬆️
ubuntu-22.04-3.13-dev 89.78% <100.00%> (+<0.01%) ⬆️
ubuntu-22.04-3.8 90.03% <100.00%> (+<0.01%) ⬆️
ubuntu-22.04-3.9 90.03% <100.00%> (+<0.01%) ⬆️
ubuntu-22.04-pypy3.10 90.10% <100.00%> (+<0.01%) ⬆️
windows-2022-3.10 90.22% <100.00%> (+<0.01%) ⬆️
windows-2022-3.11 90.16% <100.00%> (+<0.01%) ⬆️
windows-2022-3.12 90.37% <100.00%> (+<0.01%) ⬆️
windows-2022-3.13-dev 89.90% <100.00%> (+<0.01%) ⬆️
windows-2022-3.8 90.15% <100.00%> (+<0.01%) ⬆️
windows-2022-3.9 90.15% <100.00%> (+<0.01%) ⬆️
windows-2022-pypy3.10 90.22% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@akx akx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⌚ 👍

@akx akx merged commit e956b28 into python-babel:master Oct 20, 2024
26 checks passed
@tomasr8 tomasr8 deleted the parse-time branch October 20, 2024 11:30
@akx akx added this to the Babel 2.17 milestone Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

parse_time raises when a format doesn't contain seconds
2 participants