Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small test cleanup #1172

Merged
merged 4 commits into from
Jan 15, 2025
Merged

Small test cleanup #1172

merged 4 commits into from
Jan 15, 2025

Conversation

akx
Copy link
Member

@akx akx commented Jan 14, 2025

This PR:

  • separates the test_support file to multiple modules and changes those modules not to use unittest suites (so we can use e.g. parametrize)
  • removes the os_environ fixture in favor of regular pytest monkeypatch.setenv.

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.33%. Comparing base (db48791) to head (2a8cf0e).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1172   +/-   ##
=======================================
  Coverage   91.33%   91.33%           
=======================================
  Files          27       27           
  Lines        4650     4650           
=======================================
  Hits         4247     4247           
  Misses        403      403           
Flag Coverage Δ
macos-14-3.10 90.34% <ø> (ø)
macos-14-3.11 90.27% <ø> (ø)
macos-14-3.12 90.49% <ø> (ø)
macos-14-3.13 90.49% <ø> (ø)
macos-14-3.8 90.20% <ø> (ø)
macos-14-3.9 90.27% <ø> (ø)
macos-14-pypy3.10 90.34% <ø> (ø)
ubuntu-24.04-3.10 90.36% <ø> (ø)
ubuntu-24.04-3.11 90.30% <ø> (ø)
ubuntu-24.04-3.12 90.51% <ø> (ø)
ubuntu-24.04-3.13 90.51% <ø> (ø)
ubuntu-24.04-3.8 90.23% <ø> (ø)
ubuntu-24.04-3.9 90.29% <ø> (ø)
ubuntu-24.04-pypy3.10 90.36% <ø> (ø)
windows-2022-3.10 90.37% <ø> (ø)
windows-2022-3.11 90.31% <ø> (ø)
windows-2022-3.12 90.52% <ø> (ø)
windows-2022-3.13 90.52% <ø> (ø)
windows-2022-3.8 90.34% <ø> (ø)
windows-2022-3.9 90.30% <ø> (ø)
windows-2022-pypy3.10 90.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@akx akx marked this pull request as ready for review January 14, 2025 15:18
@akx akx added this to the Babel 2.17 milestone Jan 14, 2025
@akx akx requested a review from tomasr8 January 14, 2025 15:24
@akx
Copy link
Member Author

akx commented Jan 14, 2025

Btw @tomasr8, don't suppose you might be attending https://fosdem.org/2025/?

@tomasr8
Copy link
Member

tomasr8 commented Jan 14, 2025

Btw @tomasr8, don't suppose you might be attending https://fosdem.org/2025/?

Actually, I am! CERN will have a stand there (and we'll have some merch too 😃)

@akx
Copy link
Member Author

akx commented Jan 14, 2025

Actually, I am! CERN will have a stand there (and we'll have some merch too 😃)

See you there then! 😄

tests/test_core.py Show resolved Hide resolved
@akx akx enabled auto-merge (squash) January 15, 2025 13:00
@akx akx merged commit 0c1091c into master Jan 15, 2025
26 checks passed
@akx akx deleted the test-clean-x branch January 15, 2025 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants