Skip to content

Commit

Permalink
Re-fetch help threads before closing.
Browse files Browse the repository at this point in the history
This ensures that the thread title is up-to-date. Previously, even if someone changed the title of the thread, the bot might prepend the lock emoji to an older version of the title.
  • Loading branch information
swfarnsworth committed Jan 4, 2025
1 parent 3972006 commit 3df806e
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions bot/exts/help_channels/_channel.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@

import arrow
import discord
import pydis_core
from pydis_core.utils import scheduling
from pydis_core.utils.channel import get_or_fetch_channel

Expand Down Expand Up @@ -44,6 +45,9 @@ def is_help_forum_post(channel: discord.abc.GuildChannel) -> bool:

async def _close_help_post(closed_post: discord.Thread, closing_reason: _stats.ClosingReason) -> None:
"""Close the help post and record stats."""
# Get Thread with updated metadata (such as the title)
closed_post = await pydis_core.utils.channel.get_or_fetch_channel(bot.instance, closed_post.id)

embed = discord.Embed(description=CLOSED_POST_MSG)
embed.set_author(name=f"{POST_TITLE} closed", icon_url=CLOSED_POST_ICON_URL)
message = ""
Expand Down

0 comments on commit 3df806e

Please sign in to comment.